The Wayback Machine - https://web.archive.org/web/20201212160233/https://github.com/vuejs/vue-test-utils/pull/1188
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wrapper): allow destroy() method to work with functional components #1188

Merged
merged 11 commits into from Mar 22, 2019

Conversation

@tmorehouse
Copy link
Contributor

@tmorehouse tmorehouse commented Mar 16, 2019

Currently when calling wrapper.destroy(), only non-functional components are removed from the DOM.

This PR allows functional components to be removed from the DOM as well.

xref #1185 #1185 (comment)

tmorehouse added 6 commits Mar 16, 2019
Currently when calling `wrapper.destroy()`, only non-functional components are removed from the DOM.

This PR allows functional components to be removed from the DOM as well.
@tmorehouse tmorehouse marked this pull request as ready for review Mar 16, 2019
tmorehouse added 2 commits Mar 17, 2019
docs/api/options.md Outdated Show resolved Hide resolved
@eddyerburgh
Copy link
Member

@eddyerburgh eddyerburgh commented Mar 22, 2019

Thanks for this, I'll merge once you've made the changes. Be warned that it might be some time before this is released, as the next version contains many breaking changes

eddyerburgh and others added 3 commits Mar 22, 2019
Co-Authored-By: tmorehouse <troymore@nbnet.nb.ca>
Co-Authored-By: tmorehouse <troymore@nbnet.nb.ca>
Co-Authored-By: tmorehouse <troymore@nbnet.nb.ca>
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Thanks :)

@eddyerburgh eddyerburgh merged commit f4ea3fd into vuejs:dev Mar 22, 2019
11 checks passed
11 checks passed
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: build_test Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test_version_2.0.8 Your tests passed on CircleCI!
Details
ci/circleci: test_version_2.1.10 Your tests passed on CircleCI!
Details
ci/circleci: test_version_2.2.6 Your tests passed on CircleCI!
Details
ci/circleci: test_version_2.3.4 Your tests passed on CircleCI!
Details
ci/circleci: test_version_2.4.2 Your tests passed on CircleCI!
Details
ci/circleci: test_version_2.5.13 Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
@tmorehouse tmorehouse deleted the tmorehouse:patch-1 branch Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.