Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFibonacci sequence should start with [0, 1] and not [1, 1] #708
Comments
|
i will work on it! |
|
@ales-blaze I have already fixed the bug because I was really bored. See the attached PR. Furthermore: This bugfix was not intended to include major restructures but I highly suggest restructuring this repo and updating the code in order to keep up some quality in an additional issue. |
|
I will try it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
The Fibonacci sequence is defined by following statement:
F(n) = F(n-1) + F(n-2) with F(0) = 0 and F(1) = 1. For reference, please see The online encyclopedia of integer sequences as primary reference, leading to other references with more detailed description.
(Older) books sometimes omit the preceding 0, but this representation is deprecated.
Current status
fibMemo
When calling the function Fibonacci.fibMemo, the result of F(0) = 1. This is incorrect since F(0) = 0. Furthermore this leads to the following sequence for the first few integers: [1, 1, 1, 2, 3, 5, ...] for input=[0, 1, 2, 3, 4, 5, ...].
fibBotUp
When calling the function Fibonacci.fibBotUp, the program throws an exception when trying to get the value for F(0) from the map. Therefore F(0) is not supported by this implementation.
Task
Fix both implementation(s) to
a) Return correct values for F(x)
b) Do not throw exceptions
Acceptance criteria is met when both functions return [0, 1, 1, 2, 3, 5] for input=[0, 1, 2, 3, 4, 5].