bpo-36292: Mark unreachable code as such #12333
Conversation
Objects/longobject.c
Outdated
| @@ -4638,6 +4638,8 @@ long_bitwise(PyLongObject *a, | ||
| break; | ||
| default: | ||
| PyErr_BadArgument(); |
There was a problem hiding this comment.
This is deadcode: long_bitwise() is a private function only called with '&', '^' or '|'. So I would prefer to use "Py_UNREACHABLE();" here.
Objects/longobject.c
Outdated
| @@ -4666,6 +4668,9 @@ long_bitwise(PyLongObject *a, | ||
| break; | ||
| default: | ||
| PyErr_BadArgument(); |
There was a problem hiding this comment.
Ditto: use "Py_UNREACHABLE();" instead. No need to both with references. It's deadcode.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
b75a16b to
96ad058
Compare
|
The news entry was deleted and |
Objects/longobject.c
Outdated
| @@ -4637,8 +4637,8 @@ long_bitwise(PyLongObject *a, | ||
| size_z = negb ? size_b : size_a; | ||
| break; | ||
| default: | ||
| PyErr_BadArgument(); | ||
| return NULL; | ||
| /* Unreachable code */ |
There was a problem hiding this comment.
I concur with @terryjreedy: the comment (here and above) is redudant, please remove it.
https://bugs.python.org/issue36292