Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprises[MRG] MNT Update copyright year for 2019 #12964
Merged
+2
−2
Conversation
nixphix
changed the title
MNT Update copyright year for 2019
[MRG] MNT Update copyright year for 2019
Jan 12, 2019
qinhanmin2014
approved these changes
Jan 12, 2019
|
thanks @nixphix |
qinhanmin2014
merged commit 2955129
into
scikit-learn:master
Jan 12, 2019
11 checks passed
LGTM analysis: C/C++
No code changes detected
Details
LGTM analysis: JavaScript
No code changes detected
Details
LGTM analysis: Python
No alert changes
Details
ci/circleci: deploy
Your tests passed on CircleCI!
Details
ci/circleci: doc
Your tests passed on CircleCI!
Details
ci/circleci: doc-min-dependencies
Your tests passed on CircleCI!
Details
ci/circleci: lint
Your tests passed on CircleCI!
Details
codecov/patch
Coverage not affected when comparing d300f40...26e3b39
Details
codecov/project
92.34% remains the same compared to d300f40
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
No the python copyrights should be frozen with the date the code was taken, I think |
This comment has been minimized.
This comment has been minimized.
Ok good to know |
xhlulu
added a commit
to xhlulu/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhlulu
added a commit
to xhlulu/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhlulu
added a commit
to xhlulu/scikit-learn
that referenced
this pull request
Apr 28, 2019
koenvandevelde
added a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.


nixphix commentedJan 12, 2019
Happy new year🎉
following showed up in my grep, do they need update?
scikit-learn/sklearn/utils/_pprint.py
Lines 4 to 7 in a50c03f
scikit-learn/sklearn/utils/_pprint.py
Lines 27 to 29 in a50c03f