The Wayback Machine - https://web.archive.org/web/20190603113507/https://github.com/kubernetes/kubernetes/pull/72584
Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
Sign in Sign up

/kubernetes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install CRD's in local cluster #72584

Merged
merged 1 commit into from Jan 19, 2019
Merged

Conversation

Reviewers

@bertinatto bertinatto

@jbeda jbeda

Assignees

@dims dims

@bertinatto bertinatto

@msau42 msau42

Labels
approved cncf-cla: yes kind/feature lgtm needs-priority ok-to-test release-note sig/storage size/S
Projects
None yet
Milestone
No milestone
7 participants
@xing-yang @k8s-ci-robot @msau42 @fejta @fejta-bot @bertinatto @dims
@xing-yang
Copy link
Contributor

commented Jan 4, 2019 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR installs CSIDriver and CSINodeInfo CRD's in the local cluster.

Which issue(s) this PR fixes:

Fixes #70791

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Install CSINodeInfo and CSIDriver CRDs in the local cluster.

@k8s-ci-robot k8s-ci-robot added release-note kind/feature size/M cncf-cla: yes needs-sig needs-priority labels Jan 4, 2019

@k8s-ci-robot

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jan 4, 2019

Hi @xing-yang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test label Jan 4, 2019

@k8s-ci-robot k8s-ci-robot requested review from fejta and jbeda Jan 4, 2019

@xing-yang

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jan 4, 2019

@msau42 @saad-ali
@msau42

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 4, 2019

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot assigned msau42 Jan 4, 2019

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm and removed needs-ok-to-test labels Jan 4, 2019

@xing-yang

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jan 5, 2019

/test pull-kubernetes-local-e2e
@fejta

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jan 7, 2019

/approve

@k8s-ci-robot k8s-ci-robot added the approved label Jan 7, 2019

@xing-yang

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jan 7, 2019

/test pull-kubernetes-local-e2e
@fejta

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jan 7, 2019

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from fejta Jan 7, 2019

@fejta-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jan 7, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.
@msau42

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 8, 2019

/lgtm cancel
@xing-yang the failure looks like it might be an issue caused by the PR:

W0107 23:56:11.022] /go/src/k8s.io/kubernetes/hack/local-up-cluster.sh: line 868: ps: command not found

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 8, 2019

@xing-yang xing-yang force-pushed the xing-yang:local_cluster branch from 83067a5 to f610520 Jan 8, 2019

@bertinatto

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 8, 2019

/retest
@bertinatto

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 8, 2019

/sig storage
@bertinatto

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 8, 2019

/retest
@bertinatto

bertinatto reviewed Jan 8, 2019
View changes

hack/local-up-cluster.sh
echo "No csinodeinfo available."
fi
}

This comment has been minimized.

Sign in to view
Copy link
@bertinatto

bertinatto Jan 8, 2019

Member

Alternative: we could unify this into a create_crd function that takes a YAML file as parameter.

This comment has been minimized.

Sign in to view
Copy link
@xing-yang

xing-yang Jan 8, 2019

Author Contributor

Sure
@bertinatto

bertinatto reviewed Jan 8, 2019
View changes

hack/local-up-cluster.sh
if [[ ${FEATURE_GATES} == *"CSINodeInfo=true"* ]]; then
create_csinodeinfo
fi

This comment has been minimized.

Sign in to view
Copy link
@bertinatto

bertinatto Jan 8, 2019

Member

I think it wouldn't install the CRDs if FEATURE_GATES is set to AllAlpha=true, right?

This comment has been minimized.

Sign in to view
Copy link
@bertinatto

bertinatto Jan 8, 2019

Member

Would it be better to do something like this instead?

if [[ "${FEATURE_GATES:-}" =~ "CSIDriverRegistry=true" || (...)

This comment has been minimized.

Sign in to view
Copy link
@xing-yang

xing-yang Jan 8, 2019

Author Contributor

Yes, I'll change it. Thanks!

@xing-yang xing-yang force-pushed the xing-yang:local_cluster branch from f610520 to 4852266 Jan 8, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed size/M labels Jan 8, 2019

@xing-yang

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jan 9, 2019

/test pull-kubernetes-e2e-gce-100-performance
@xing-yang

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jan 9, 2019

/test pull-kubernetes-e2e-kops-aws
@bertinatto

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 9, 2019

/test pull-kubernetes-local-e2e
@bertinatto

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 9, 2019

Interesting, occasionally pkill won't be found in $PATH:

201 | W0109 09:35:35.834] 2019/01/09 09:35:35 process.go:153: Running: pkill hyperkube
202 | W0109 09:35:35.884] 2019/01/09 09:35:35 process.go:155: Step 'pkill hyperkube' finished in 110.094µs
203 | W0109 09:35:35.884] 2019/01/09 09:35:35 local.go:225: unable to kill hyperkube processes: error starting pkill hyperkube: exec: "pkill": executable file not found in $PATH
204 | W0109 09:35:35.884] 2019/01/09 09:35:35 process.go:153: Running: pkill etcd
205 | W0109 09:35:35.885] 2019/01/09 09:35:35 process.go:155: Step 'pkill etcd' finished in 8.562µs
@xing-yang
Install CRDs in local cluster 
This PR installs CSIDriver and CSINodeInfo CRDs in the
local cluster.

fixes: #70791
Loading status checks…
3603013

@xing-yang xing-yang force-pushed the xing-yang:local_cluster branch from 4852266 to 3603013 Jan 18, 2019

@k8s-ci-robot

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jan 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@xing-yang

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jan 18, 2019

/test pull-kubernetes-integration
@xing-yang

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jan 18, 2019

/test pull-kubernetes-e2e-kops-aws
@dims

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 18, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot assigned dims Jan 18, 2019

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 18, 2019

@bertinatto

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 19, 2019

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage and removed needs-sig labels Jan 19, 2019

@bertinatto

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 19, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot assigned bertinatto Jan 19, 2019

@k8s-ci-robot k8s-ci-robot merged commit 6ce59dd into kubernetes:master Jan 19, 2019
18 checks passed

18 checks passed

cla/linuxfoundation xing-yang authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Job succeeded.
Details
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@xing-yang xing-yang referenced this pull request Jan 21, 2019

Closed

REQUEST: New membership for xing-yang #393

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.