The Wayback Machine - https://web.archive.org/web/20190322181109/https://github.com/angular/angular/pull/25992
Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
Sign in Sign up

/angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update .nvmrc file to correct node version #25992

Closed
wants to merge 1 commit into
base: master
from
Closed

build: update .nvmrc file to correct node version #25992

wants to merge 1 commit into from

Conversation

Reviewers

@alexeagle alexeagle

@IgorMinar IgorMinar

Assignees
No one assigned
Labels
PR action: merge PR target: master & patch cla: yes comp: build & ci type: bug/fix
Projects
None yet
Milestone
  v7.0
4 participants
@petebacondarwin @alexeagle @IgorMinar @googlebot
@petebacondarwin
Copy link
Member

petebacondarwin commented Sep 18, 2018

The version was updated in 34ec924
but this file got missed.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information
@petebacondarwin
build: update .nvmrc file to correct node version 
The version was updated in 34ec924
but this file got missed.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ffa4866

@petebacondarwin petebacondarwin added type: bug/fix comp: build & ci PR target: master & patch labels Sep 18, 2018

@petebacondarwin petebacondarwin added this to the v7.0 milestone Sep 18, 2018

@googlebot googlebot added the cla: yes label Sep 18, 2018

@petebacondarwin petebacondarwin requested review from IgorMinar and alexeagle Sep 18, 2018

@alexeagle

alexeagle approved these changes Sep 18, 2018
View changes

@alexeagle alexeagle added the PR action: merge label Sep 18, 2018

@IgorMinar

IgorMinar approved these changes Sep 18, 2018
View changes

benlesh added a commit that referenced this pull request Sep 18, 2018

@petebacondarwin @benlesh
build: update .nvmrc file to correct node version (#25992) 
The version was updated in 34ec924
but this file got missed.
PR Close #25992
Loading status checks…
c693624

@benlesh benlesh closed this in 56283ed Sep 18, 2018

FrederikSchlemmer added a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

@petebacondarwin @FrederikSchlemmer
build: update .nvmrc file to correct node version (angular#25992) 
The version was updated in angular@34ec924
but this file got missed.
PR Close angular#25992
c611a42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.