github / rubocop-github Public
master
Commits on Jan 19, 2022
-
Merge pull request #96 from github/bump-to-0.17.0
Release v0.17.0
-
* Remove version constraints for rubocop, rubocop-performance, and rubocop-rails * Test against Ruby 3.1
Commits on Jan 14, 2022
-
Merge pull request #95 from github/bump-ruby
Bump all dev dependencies
-
This commit bumps all development dependencies, and removes pessimistic version constraints where possible now that we've got a Gemfile.lock checked in. We had to keep the constraint for Rails for now, since Rails 7 is not compatible with Ruby 2.6. We can bump Rails if we drop Ruby 2.6. None of this affects the released gem, so as long as tests still pass we are in good shape.
-
Merge pull request #94 from github/bump-ruby
Test against Ruby 3.1
-
-
Merge pull request #93 from github/version-constraints
Remove version constraints for rubocop libraries
-
Add Gemfile.lock to version control
Related to removing version constraints in 286944a, Running locked version of these in CI will help avoid unexpected failures for unrelated changes.
Commits on Jan 11, 2022
-
Remove version constraints for rubocop libraries
These constraints make it more difficult to upgrade these libraries in projects that use rubocop-github. I think the idea here was that we'd be able to bump the version alongside the default config, but without locking to an exact version we can still end up with a config that is incompatible with certain rubocop version (see the unrecognized cop error in #86, for example). If anything, I'd prefer a `>=` constraint over a `<=`. That would allow us to bump the minimum constraint when we add new cops, but still freely upgrade in our projects as long as there are no config incompatibilities (which are less common anyway ever since RuboCop 1.0).
Commits on Jan 8, 2022
-
Merge pull request #83 from vitorgalvao/patch-1
STYLEGUIDE.md: consistent ordering of bad and good
-
-
Merge pull request #84 from vitorgalvao/patch-2
STYLEGUIDE.md: consistent use of parenthesis on Keyword Arguments
-
-
Commits on Jun 24, 2021
-
Merge pull request #90 from github/release-0.16.2
release v0.16.2
-
-
Merge pull request #89 from github/component-with-content
Add support for rendering ViewComponents `with_content`
Commits on Jun 18, 2021
-
https://github.com/rubocop/rubocop-ast/blob/master/docs/modules/ROOT/pages/node_pattern.adoc ^ Was JUST enough context for me to figure this out!
-
Commits on Jun 16, 2021
Commits on Apr 26, 2021
-
Merge pull request #85 from github/bump-rubocop-version
Bump rubocop & rubocop-performance version
Commits on Apr 24, 2021
-
-
Bump rubocop to allow version 1.13.0
Version 1.4 of rubocop introduced a breaking change that creates some warnings and issues when using `parser/ruby27`, this issue was fixed in rubocop/rubocop#9702 and released in 1.13.0
Commits on Feb 22, 2021
Commits on Jan 16, 2021
-
Merge pull request #78 from github/render_local_literal_keys
Enforce local keys being literals
Commits on Jan 14, 2021
Commits on Jan 4, 2021
-
Merge pull request #79 from spraints/insecure-hash-algorithms
Add check for insecure hash algorithms
-
Commits on Dec 17, 2020
-
Merge pull request #80 from github/update-gems-for-ruby-3
Update gems for ruby 3
Commits on Dec 14, 2020
-
-
Update gems to be compatible with ruby 3
update minitest from 5.10 to 5.14 update rubocop to 1.6.1
Commits on Dec 11, 2020
-
Add special checks for rails's Digest::UUID
https://api.rubyonrails.org/classes/Digest/UUID.html uuid_v3 uses MD5, so it's only allowed when MD5 is in the "Allowed" list. uuid_v5 uses SHA1, so it's only allowed when SHA1 is in the "Allowed" list.

