The Wayback Machine - https://web.archive.org/web/20201226153222/https://github.com/github/homebrew-bootstrap/pull/60
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix brew-upgrade-mysql for latest changes #60

Merged
merged 4 commits into from Jun 13, 2018
Merged

Conversation

@mistydemeo
Copy link
Member

@mistydemeo mistydemeo commented Jun 13, 2018

Homebrew has now shipped MySQL 8.0 as mysql, which has exposed a few bugs with the logic in this script. Namely:

  • A few places start and stop mysql instead of mysql@5.7, assuming that they're equivalent, which they no longer are.
  • The current/installed versions are looked up as mysql instead of mysql@5.7.
  • We should no longer allow mysql to be considered the correct package.

I've tested, and this will safely migrate users to the versioned package.

@mistydemeo mistydemeo merged commit 5be937c into master Jun 13, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mistydemeo mistydemeo deleted the fix_mysql_upgrade branch Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.