The Wayback Machine - https://web.archive.org/web/20201220221951/https://github.com/lodash/lodash/pull/3487
Skip to content
Sign up
Sign in Sign up

/ lodash

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove `map` example from `parseInt` and `trim` #3487

Merged
merged 1 commit into from Nov 10, 2017
Merged

Remove `map` example from `parseInt` and `trim` #3487

merged 1 commit into from Nov 10, 2017

Conversation

@younesfkihi
Copy link
Contributor

@younesfkihi younesfkihi commented Nov 10, 2017

The examples where parseInt and trim are used with map are not valid anymore because the guard param was removed:

map(['6', '08', '10'], parseInt)
 // => [6, NaN, 2]
map(['  foo  ', '  bar  '], trim)
 // => ['  foo  ', '  bar  ']
Younes
Remove `map` examples from `parseInt` and `trim`
Loading status checks…
7902ab4
@jdalton
Copy link
Member

@jdalton jdalton commented Nov 10, 2017

Thank you @younesfkihi! Nice catch!
@jdalton jdalton merged commit 8464b18 into lodash:master Nov 10, 2017
2 checks passed
2 checks passed
Node Security No known vulnerabilities found
Details
licence/cla Contributor License Agreement is signed.
Details
@younesfkihi younesfkihi deleted the younesfkihi:doc-fix-1 branch Nov 10, 2017
This was referenced Apr 19, 2018
Closed
Closed
Closed
Closed
@lock
Copy link

@lock lock bot commented Dec 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@younesfkihi @jdalton
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.