The Wayback Machine - https://web.archive.org/web/20220922072117/https://github.com/aspnet/Mvc/issues/6294
Skip to content
Sign up
This repository has been archived by the owner. It is now read-only.

Exception thrown when attempting to use model members in sections in a Razor Page #6294

Closed
DamianEdwards opened this issue May 18, 2017 · 4 comments
Closed

Exception thrown when attempting to use model members in sections in a Razor Page #6294

DamianEdwards opened this issue May 18, 2017 · 4 comments
Assignees
@rynowak
Labels
3 - Done bug feature-Razor-Pages
Projects
Razor Pages 2.0.0-preview2
Milestone
2.0.0-preview2

Comments

@DamianEdwards
Copy link
Member

DamianEdwards commented May 18, 2017 •
edited

Repro

  1. Create a new Razor Pages project in Visual Studio
  2. Open the Index.cshtml.cs model class file
  3. Add a property to be accessed from the page's CSHTML file: public string Message { get; set; } = "Hello";
  4. Open the Index.cshtml page file
  5. Attempt to render the value of Model.Message inside the "Scripts" section: 
    @section Scripts {
   <h1>@Model.Message</h1>
}

Expected Result

The message is rendered in the HTML OK.

Actual Result

InvalidCastException: Unable to cast object of type 'Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[System.Object]' to type 'Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[WebApplication26.Pages.IndexModel]'.

@rynowak @NTaylorMullen
@DamianEdwards DamianEdwards added this to the 2.0.0-preview2 milestone May 18, 2017
@Eilon
Copy link
Member

Eilon commented May 18, 2017

@rynowak - please reassign as appropriate.

@rynowak
Copy link
Member

rynowak commented May 19, 2017 •
edited

Razor generates a property like the following. Code here

public ViewDataDictionary<TModel> ViewData => (ViewDataDictionary<TModel>)PageContext?.ViewData;

It's this cast operation that's blowing up.

When we're executing the Layout, we'll set ViewContext.ViewData here to the appropriate type for the Layout page, which will be ViewDataDictionary<object>.

I'm not sure why it's the same ViewContext. We should be providing a different ViewContext to the Layout.

@rynowak rynowak moved this from Ready to Working in Razor Pages 2.0.0-preview2 May 19, 2017
@rynowak
Copy link
Member

rynowak commented May 23, 2017

#6310 will accomplish the bulk of what we need to do. I'll do a follow up afterwards to add a test

rynowak added a commit that referenced this issue May 24, 2017
@rynowak
Add a test for #6294
6b3e89e 
This case was fixed by 2992f8e - this commit just adds a test to verify
the fix.
rynowak added a commit that referenced this issue May 24, 2017
@rynowak
Add a test for #6294
c1dd95b 
This case was fixed by 2992f8e - this commit just adds a test to verify
the fix.
@rynowak
Copy link
Member

rynowak commented May 25, 2017

Fixed by: 2992f8e
Test Added: c1dd95b

@rynowak rynowak closed this as completed May 25, 2017
@rynowak rynowak moved this from Working to Done in Razor Pages 2.0.0-preview2 May 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rynowak rynowak

Labels
3 - Done bug feature-Razor-Pages
Projects
No open projects
Razor Pages 2.0.0-preview2
Done
Milestone
2.0.0-preview2
Development

No branches or pull requests
3 participants
@Eilon @DamianEdwards @rynowak
Morty Proxy This is a proxified and sanitized view of the page, visit original site.