The Wayback Machine - https://web.archive.org/web/20220922071739/https://github.com/aspnet/Mvc/issues/5625
Skip to content
Sign up
This repository has been archived by the owner. It is now read-only.

Wrong docs ApiRequestFormat #5625

Closed
rynowak opened this issue Dec 20, 2016 · 2 comments
Closed

Wrong docs ApiRequestFormat #5625

rynowak opened this issue Dec 20, 2016 · 2 comments
Assignees
@jbagga
Labels
3 - Done bug
Milestone
2.0.0-preview1

Comments

@rynowak
Copy link
Member

rynowak commented Dec 20, 2016

I suspect too much copy-paste, not enough coffee ☕️

Mvc/src/Microsoft.AspNetCore.Mvc.ApiExplorer/ApiDescription.cs

Line 50 in 760c8f3

/// Will be empty if the action returns no response, or if the response type is unclear. Use

@Eilon Eilon added this to the 2.0.0 milestone Dec 20, 2016
@jbagga
Copy link
Contributor

jbagga commented Dec 22, 2016

What is it supposed to be?

/// <summary>
/// Gets the list of possible formats for a request.
/// </summary>

Anything else that I should find out to add to the Remarks section?

@jbagga jbagga mentioned this issue Dec 22, 2016
Merged
@rynowak
Copy link
Member Author

rynowak commented Dec 27, 2016

I would add a similar blurb to the remarks. It will be empty if the action doesn't take a 'body' parameter.

jbagga added a commit that referenced this issue Jan 5, 2017
@jbagga
Edited docs, removed unnecessary usings for ApiDescription (#5634)
9cc20ff 
Addresses #5625
@jbagga jbagga closed this as completed Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jbagga jbagga

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
3 participants
@Eilon @rynowak @jbagga
Morty Proxy This is a proxified and sanitized view of the page, visit original site.