Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
SkipUnmount support and set default clang for cross build #15528
Conversation
|
Confirmed that, with this change, we successfully can build CoreFX for Ubuntu 14.04 and 16.04 arm32. |
| @@ -150,8 +150,8 @@ __UnprocessedBuildArgs= | ||
| __CrossBuild=0 | ||
| __ServerGC=0 | ||
| __VerboseBuild=false | ||
| __ClangMajorVersion=3 | ||
| __ClangMinorVersion=5 | ||
| __ClangMajorVersion=0 |
janvorli
Jan 26, 2017
Member
Hm, what is the difference between setting the default version here and at the other place? If we set it here, it can be overriden by the command line option. If there is no clang option, it would take this default version.
If we do it this new way, then the effect is the same. If the command line option is used, the version is set accordingly. If it is not set, we set it later to the default one.
Hm, what is the difference between setting the default version here and at the other place? If we set it here, it can be overriden by the command line option. If there is no clang option, it would take this default version.
If we do it this new way, then the effect is the same. If the command line option is used, the version is set accordingly. If it is not set, we set it later to the default one.
gkhanna79
Jan 26, 2017
Author
Member
I am simply trying to define a consistent way to go about this.
I am simply trying to define a consistent way to go about this.
janvorli
Jan 26, 2017
Member
Interesting. I was convinced it is the other way in the build.sh in coreclr. Obviously I was wrong.
Interesting. I was convinced it is the other way in the build.sh in coreclr. Obviously I was wrong.
|
LGTM, thank you! |
Similar to CoreCLR repo, add support to skip unmounting when using build-rootfs.sh in Docker image.
Also, define the default clang toolset to use for cross and regular builds (similar to how it is done in CoreCLR at https://github.com/dotnet/coreclr/blob/master/build.sh#L747).
@janvorli @wtgodbe PTAL