The Wayback Machine - https://web.archive.org/web/20201212153226/https://github.com/dotnet/corefx/pull/15718
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ActiveIssue attributes for #3838 #15718

Merged
merged 1 commit into from Feb 2, 2017
Merged

Conversation

@JonHanna
Copy link
Collaborator

@JonHanna JonHanna commented Feb 2, 2017

This issue was caused by dotnet/coreclr#1764 which was fixed by dotnet/coreclr#8438 and so the attribute can be removed.

Closes #3838

This issue was caused by dotnet/coreclr#1764 which was fixed by
dotnet/coreclr#8438 and so the attribute can be removed.

Closes #3838
@JonHanna
Copy link
Collaborator Author

@JonHanna JonHanna commented Feb 2, 2017

This also means that the changes made in dotnet/coreclr#8438 now have tests, which they didn't before.

Copy link
Member

@stephentoub stephentoub left a comment

Thanks!

@JonHanna
Copy link
Collaborator Author

@JonHanna JonHanna commented Feb 2, 2017

Test Innerloop OSX Debug Build and Test please
Test Innerloop OSX Release Build and Test please

(Git seems to have failed in its clone and left stuff hanging from what I can make out from https://ci.dot.net/job/dotnet_corefx/job/master/job/osx_debug_prtest/2709/console does that need to be an issue?)

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Feb 2, 2017

Git seems to have failed in its clone

Sometimes there are networking issues with the macs, FYI @mmitche.

@stephentoub stephentoub merged commit 6d85b94 into dotnet:master Feb 2, 2017
10 checks passed
10 checks passed
Innerloop CentOS7.1 Debug Build and Test Build finished.
Details
Innerloop CentOS7.1 Release Build and Test Build finished.
Details
Innerloop OSX Debug Build and Test Build finished.
Details
Innerloop OSX Release Build and Test Build finished.
Details
Innerloop PortableLinux Debug Build and Test Build finished.
Details
Innerloop PortableLinux Release Build and Test Build finished.
Details
Innerloop Ubuntu14.04 Debug Build and Test Build finished.
Details
Innerloop Ubuntu14.04 Release Build and Test Build finished.
Details
Innerloop Windows_NT Debug Build and Test Build finished.
Details
Innerloop Windows_NT Release Build and Test Build finished.
Details
@JonHanna JonHanna deleted the JonHanna:fix_3838 branch Feb 2, 2017
@karelz karelz modified the milestone: 2.0.0 Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.