The Wayback Machine - https://web.archive.org/web/20160820043105/https://github.com/github/VisualStudio/pull/509
Skip to content
Sign up Sign in

/VisualStudio

Fix branch comparison in PR creation #509

Merged
merged 1 commit into from Aug 19, 2016
+1 −1

Labels

Ready for Review

Milestone

No milestone

Assignees

No one assigned

1 participant

@shana
@shana
shana commented Aug 19, 2016

The Name property is not enough, and IBranch is comparable, use Equals for best results.

@shana shana Compare branches properly

All checks have passed

5 successful checks
Details
@github-cla GitHub CLA — @shana has accepted the GitHub Contributor License Agreement.
Details
@hubot VisualStudio — Build #3895013 succeeded in 82s
Details
continuous-integration/appveyor/branch — AppVeyor build succeeded
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
@hubot jenkins/build_log — Jenkins Build Log
3a81551
@shana shana merged commit 2712ff7 into master Aug 19, 2016
5 checks passed

5 checks passed

Details GitHub CLA @shana has accepted the GitHub Contributor License Agreement.
Details VisualStudio Build #3895013 succeeded in 82s
Details continuous-integration/appveyor/branch AppVeyor build succeeded
Details continuous-integration/appveyor/pr AppVeyor build succeeded
Details jenkins/build_log Jenkins Build Log
@shana shana deleted the fixes/branch-validation-incomplete branch Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can't perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.