The Wayback Machine - https://web.archive.org/web/20160820044515/https://github.com/github/VisualStudio/issues/455
Skip to content

"Source branch does not exist remotely" being shown when creating PR, though it does exist remotely #455

Closed
grokys opened this Issue Jul 27, 2016 · 1 comment

2 participants

@grokys

Using 2.0.0 RC1 the following message is shown:

image

Even when the source branch does exist remotely.

This is happening because BranchValidator is first called with null before being called with the BranchModel.

@grokys

Looking into this more, what is happening is:

  • Branches is set from Initialize
  • Because Branches has changed the UI layer's selection is no longer valid so it sets its selection to null
  • This selection is two-way bound to SourceBranch so this is set to null
  • The BranchValidator notices this and things that the source branch doesn't exist remotely
  • This line is then triggered, setting the SourceBranch
  • BranchValidator is called again with the correct info and the validation passes, but at this point it's too late - the notification has already been sent.
@paladique paladique added the bug label Jul 27, 2016
@grokys grokys added a commit that referenced this issue Jul 28, 2016
@grokys grokys Correctly validate source branch.
Don't try to validate source branch using `BranchValidator` while initialization is in progress. Fixes #455.
43a6982
@paladique paladique closed this in #460 Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can't perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.