The Wayback Machine - https://web.archive.org/web/20160820044521/https://github.com/github/VisualStudio/issues/390
Skip to content
Sign up Sign in

/VisualStudio

New issue

[None] Gets added twice to PR list filters #390

Closed
grokys opened this Issue Jul 5, 2016 · 3 comments

Labels

bug

Milestone

No milestone

Assignees

No one assigned

3 participants

@grokys @shana @paladique
@grokys
grokys commented Jul 5, 2016 • edited

To repro: open the VisualStudio repository, then go to PR list. Select "donokuda" as asignee. The [None] entry in the dropdown gets duplicated,

image

@grokys grokys added the bug label Jul 5, 2016
@shana
shana commented Jul 5, 2016

What's up with the title?

@grokys
grokys commented Jul 5, 2016

Oops, I thought I edited that.

@grokys grokys changed the title from [None to [None] Gets added twice to PR list filters Jul 5, 2016
@grokys grokys added a commit that referenced this issue Jul 5, 2016
@grokys grokys Don't display [None] twice. 
The empty list item was getting added twice: once by the XAML and once
in PullRequestListViewModel. This removes the XAML empty list item code
as I assume it's supposed to be set in the VM. Fixes #390.
 5fdff92
@grokys grokys referenced this issue Jul 5, 2016
Merged

Don't display [None] twice. #393

@paladique
GitHub member
paladique commented Jul 5, 2016

Seeing this too. An additional thing to note here is that if you end up selecting the first [None] in the list, the duplicated [None] disappears.

@grokys grokys referenced this issue Jul 6, 2016
Closed

Assignee dropdown has no assignees #413

@shana shana closed this in #393 Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can't perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.