The Wayback Machine - https://web.archive.org/web/20160820044548/https://github.com/github/VisualStudio/issues/109
Skip to content

Ctrl-clicking a selection in the list doesn't remove the selection and disable the clone button #109

Closed
amytruong opened this Issue Sep 30, 2015 · 1 comment

3 participants

@amytruong

Steps to reproduce:
1. Click on Clone action link
2. Select a repo in the list
3. ctrl-click the selection to unselect it

Expected Results: The selection is un-selected and the clone button is disabled

Actual Results: Nothing. I can un-select a repo by clicking outside the list (but inside the box). I am on a Mac so I tried control + clicking and cmd/command+ clicking as well. Hoping @shana can just take a 👀 for me.
👇 is just to show that I can click outside the list but inside the box to unselect. 😁
select

@grokys
grokys commented Jul 5, 2016 edited

This is now fixed, however re-selecting the item doesn't re-enable the Clone button so there's still a bug.

@grokys grokys self-assigned this Jul 5, 2016
@grokys grokys added a commit that referenced this issue Jul 5, 2016
@grokys grokys Correctly check for existing repo in clone dialog.
The clone dialog was validating for the presence of an existing repo at
the destination path, but the validation was dependent upon the
_previous_ validation state. Make sure the current path is always
validated. Fixes #394. Fixes #109.
7ae113c
@shana shana closed this in #395 Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can't perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.