The Wayback Machine - https://web.archive.org/web/20201212185950/https://github.com/dotnet/corefx/pull/7600
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IntPtr-based file descriptors exclusively, in native calls from Sockets code, part 2 #7600

Merged
merged 1 commit into from Apr 8, 2016

Conversation

@ericeil
Copy link
Contributor

@ericeil ericeil commented Apr 8, 2016

Part 2 of the fix for #6928. Change signatures of the "permanent" native networking methods to take IntPtr arguments, and switch back to using those methods. Once this change propagates everywhere, we can remove the *_IntPtr methods introduced in #7587.

@stephentoub

…e IntPtr arguments, and switch back to using those methods. Once this change propagates everywhere, we can remove the *_IntPtr methods.
@stephentoub
Copy link
Member

@stephentoub stephentoub commented Apr 8, 2016

LGTM

@ericeil ericeil merged commit 023e414 into dotnet:master Apr 8, 2016
8 checks passed
8 checks passed
Innerloop CentOS7.1 Debug Build and Test Build finished. No test results found.
Details
Innerloop CentOS7.1 Release Build and Test Build finished. No test results found.
Details
Innerloop OSX Debug Build and Test Build finished. No test results found.
Details
Innerloop OSX Release Build and Test Build finished. No test results found.
Details
Innerloop Ubuntu Debug Build and Test Build finished. No test results found.
Details
Innerloop Ubuntu Release Build and Test Build finished. No test results found.
Details
Innerloop Windows_NT Debug Build and Test Build finished. 143528 tests run, 42 skipped, 0 failed.
Details
Innerloop Windows_NT Release Build and Test Build finished. 143525 tests run, 42 skipped, 0 failed.
Details
@ericeil ericeil deleted the ericeil:NoManualSafeHandle2 branch Jun 17, 2016
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
@karelz karelz added the os-linux label Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.