Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fixing #7455 to re-enable test filtering #7535
Conversation
| @@ -1,8 +1,5 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup> |
weshaggard
Apr 6, 2016
Member
Why are you removing these defaults? What happens now if you build one of these csproj's without passing in a configuration or osgroup?
Why are you removing these defaults? What happens now if you build one of these csproj's without passing in a configuration or osgroup?
jonmill
Apr 6, 2016
Author
Contributor
The System.Data.SqlClient csproj files do not have any OS-Specific includes so the Debug default will be fine. The Runtime.PInvoke csproj also does not have any OS-Specific includes but also has a default include in a later PropertyGroup, so the Windows Specific one was actually incorrect
The System.Data.SqlClient csproj files do not have any OS-Specific includes so the Debug default will be fine. The Runtime.PInvoke csproj also does not have any OS-Specific includes but also has a default include in a later PropertyGroup, so the Windows Specific one was actually incorrect
weshaggard
Apr 6, 2016
Member
Even though System.Data.SqlClient might not have any OS-specific stuff the test project here does have a configuration section for the OS-specific stuff. If it isn't OS specific then we should also clean-up the configurations.
Even though System.Data.SqlClient might not have any OS-specific stuff the test project here does have a configuration section for the OS-specific stuff. If it isn't OS specific then we should also clean-up the configurations.
|
LGTM after green CI. |
b02e7e8
into
dotnet:master
Re-enabling binary filter for the test binaries where only the binaries for the platform specified will be built.
/cc @weshaggard - FYI that the
$(TargetsUnix)part did not work for some reason, not sure why/fyi @mellinoe