The Wayback Machine - https://web.archive.org/web/20201118160629/https://github.com/golang/gddo/issues/310
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight destination identifier on in-page navigation #310

Closed
wallclockbuilder opened this issue Sep 2, 2015 · 7 comments
Closed

Highlight destination identifier on in-page navigation #310

wallclockbuilder opened this issue Sep 2, 2015 · 7 comments

Comments

@wallclockbuilder
Copy link

@wallclockbuilder wallclockbuilder commented Sep 2, 2015

Selecting a function only works on small screens.
Heres what I mean:

When I click on a function.
screen shot 2015-09-02 at 9 39 30 am

The godoc page takes me to that function's section. However the function I'm looking for is lost among the other functions.
screen shot 2015-09-02 at 9 34 12 am

This can be improved by making the selected function stand out.
screen shot 2015-09-02 at 9 37 23 am

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Sep 2, 2015

It tries to put the function at the top of the screen, but can't because the page is too short/your browser window is tall.

So this only affects things in the bottom-most area as tall as your window.

I agree it can be improved though.

@wallclockbuilder
Copy link
Author

@wallclockbuilder wallclockbuilder commented Sep 3, 2015

You're right. It tries to put the function at the top of the screen. That usually works until it doesn't, then I get this very painful confusion because the function is supposed to be at the top of the screen but its not there. That totally destroys my flow. Its not a pleasant experience. The UX should be consistent. This is broken.

Highlighting the selected function makes the experience consistent.

@wallclockbuilder wallclockbuilder changed the title Selected function is not obvious Selected function does not work on big screens. Sep 3, 2015
@adg adg changed the title Selected function does not work on big screens. Highlight destination identifier on in-page navigation Sep 25, 2015
@adg
Copy link
Contributor

@adg adg commented Sep 25, 2015

I think the solution here is to add some javascript to highlight the target identifier on navigation. Should be pretty straightforward.

@nickrobinson
Copy link

@nickrobinson nickrobinson commented Sep 26, 2015

Taking a look at this

@nickrobinson
Copy link

@nickrobinson nickrobinson commented Sep 26, 2015

Submitted a Pull Request #328

@wallclockbuilder
Copy link
Author

@wallclockbuilder wallclockbuilder commented Sep 26, 2015

ok Thanks.

I'm reviewing your pull request now.

adg added a commit that referenced this issue Oct 1, 2015
Highlight destination identifier on in-page navigation. #310
@ghost
Copy link

@ghost ghost commented Feb 26, 2016

Should this be closed or is there more to do?

@adg adg closed this Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.