The Wayback Machine - https://web.archive.org/web/20220705025601/https://phabricator.wikimedia.org/T59401
Page MenuHomePhabricator

Padding values of div#content were (accidentially?) changed (in LESS rewrite?)
Closed, ResolvedPublic

Description

For small screens, it now has:

padding: 1.5em 1.5em 1.5em 1.75em;

For big screens (982px+), it now has:

padding: 1.25em 1.5em 1.5em;

Some time ago, these values was:

padding: 1em; (small)
padding: 1.25em 1.5em 1.5em 1.5em; (big)

Anyway it's not reasonable to use bigger paddings now for smaller screens.


Version: unspecified
Severity: normal

Details

Reference
bz57401

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:34 AM2014-11-22 02:34:09 (UTC+0)
bzimport set Reference to bz57401.
Comment Actions

Fixed in I2551ab16. I couldn't find this bug when committing that, heh.

Comment Actions

(In reply to comment #1)

Fixed in I2551ab16. I couldn't find this bug when committing that, heh.

So finally both paddings got enlarged, not changed back to original values?

Comment Actions

Oh, hmm. So it would seem, yeah.

Comment Actions

(In reply to comment #3)

Oh, hmm. So it would seem, yeah.

And it won't be changed back?

Comment Actions

Unless you submit a patch ;) The change seems unintentional to me.

Comment Actions

Change 111454 had a related patch set uploaded by Liangent:
(bug 57401) Fix padding values of div#content

https://gerrit.wikimedia.org/r/111454

Comment Actions

Change 111454 merged by jenkins-bot:
Vector: Fix padding values of div#content

https://gerrit.wikimedia.org/r/111454

Morty Proxy This is a proxified and sanitized view of the page, visit original site.