Fixed error saving APNG with duplicate frames and different duration times #5609
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes. There is a problem in that 'duration', which should be passed as an integer to the following context, is passed as a list by redefining the same variable names in lines 1062 and 1120 (if the condition: 1115 ~ 1119 is satisfied, This condition is satisfied when the same frame as the previous frame in the animated image is detected in succession.). So in this case using the round method on the list will throw an error. |
Merged
Member
|
I've created thak1411#1 with some suggestions. |
Added test
Contributor
Author
|
Thank you for your suggestion. The merge is complete. |
Contributor
Author
|
thanks @dogemad @radarhere ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5608
This issue is caused by the 'duration' variable being overwritten.
Pillow/src/PIL/PngImagePlugin.py
Line 1120 in 83c05aa
After being overwritten, the duration variable is not updated.
Pillow/src/PIL/PngImagePlugin.py
Lines 1083 to 1084 in 83c05aa