Fix PNG seek and tell #4512
Merged
Fix PNG seek and tell #4512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmrowla
reviewed
Apr 2, 2020
pmrowla
approved these changes
Apr 2, 2020
Contributor
pmrowla
left a comment
There was a problem hiding this comment.
other than the one minor comment, this should resolve the issue. It definitely should have occurred to me to test seek()/tell() on a regular PNG image in my PR, sorry about that!
Member
Author
|
Thanks, updated! Also added a test for (Travis CI has a disk space error on the s390x job and no restart button, but it's all green on my fork.) |
23 tasks
|
Thanks for the quick fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4509.
Changes proposed in this pull request:
__frameto 0 to fixseekafter open