Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5544ce4

Browse filesBrowse files
Trottdanielleadams
authored andcommitted
src: condense experimental warning message
PR-URL: #45424 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
1 parent 4283af4 commit 5544ce4
Copy full SHA for 5544ce4

File tree

Expand file treeCollapse file tree

6 files changed

+10
-12
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

6 files changed

+10
-12
lines changed
Open diff view settings
Collapse file

‎lib/internal/util.js‎

Copy file name to clipboardExpand all lines: lib/internal/util.js
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,7 @@ function slowCases(enc) {
221221

222222
function emitExperimentalWarning(feature) {
223223
if (experimentalWarnings.has(feature)) return;
224-
const msg = `${feature} is an experimental feature. This feature could ` +
225-
'change at any time';
224+
const msg = `${feature} is an experimental feature and might change at any time`;
226225
experimentalWarnings.add(feature);
227226
process.emitWarning(msg, 'ExperimentalWarning');
228227
}
Collapse file

‎src/node_process_events.cc‎

Copy file name to clipboardExpand all lines: src/node_process_events.cc
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,7 @@ Maybe<bool> ProcessEmitExperimentalWarning(Environment* env,
9292

9393
experimental_warnings.insert(warning);
9494
std::string message(warning);
95-
message.append(
96-
" is an experimental feature. This feature could change at any time");
95+
message.append(" is an experimental feature and might change at any time");
9796
return ProcessEmitWarningGeneric(env, message.c_str(), "ExperimentalWarning");
9897
}
9998

Collapse file

‎test/common/measure-memory.js‎

Copy file name to clipboardExpand all lines: test/common/measure-memory.js
+4-3Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,10 @@ function assertSingleDetailedShape(result) {
4343
}
4444

4545
function expectExperimentalWarning() {
46-
common.expectWarning('ExperimentalWarning',
47-
'vm.measureMemory is an experimental feature. ' +
48-
'This feature could change at any time');
46+
common.expectWarning(
47+
'ExperimentalWarning',
48+
'vm.measureMemory is an experimental feature and might change at any time'
49+
);
4950
}
5051

5152
module.exports = {
Collapse file

‎test/parallel/test-vfs.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-vfs.js
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ throws(() => require(vfsFile), { code: 'MODULE_NOT_FOUND' });
3434

3535
common.expectWarning(
3636
'ExperimentalWarning',
37-
'Module._stat is an experimental feature. This feature could change at any time');
37+
'Module._stat is an experimental feature and might change at any time'
38+
);
3839

3940
process.on('warning', common.mustCall());
4041

Collapse file

‎test/wasi/test-wasi-symlinks.js‎

Copy file name to clipboardExpand all lines: test/wasi/test-wasi-symlinks.js
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ const path = require('path');
55

66
if (process.argv[2] === 'wasi-child') {
77
common.expectWarning('ExperimentalWarning',
8-
'WASI is an experimental feature. This feature could ' +
9-
'change at any time');
8+
'WASI is an experimental feature and might change at any time');
109

1110
const { WASI } = require('wasi');
1211
const wasmDir = path.join(__dirname, 'wasm');
Collapse file

‎test/wasi/test-wasi.js‎

Copy file name to clipboardExpand all lines: test/wasi/test-wasi.js
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ if (process.argv[2] === 'wasi-child') {
88
const path = require('path');
99

1010
common.expectWarning('ExperimentalWarning',
11-
'WASI is an experimental feature. This feature could ' +
12-
'change at any time');
11+
'WASI is an experimental feature and might change at any time');
1312

1413
const { WASI } = require('wasi');
1514
tmpdir.refresh();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.