Commit 325254c
src: remap invalid file descriptors using
When checking for the validity of the stdio file descriptors
(#875), ones which don't exist are intended to be remapped to
/dev/null (and, if that doesn't work, we abort).
This however doesn't work on all platforms and in all cases, and is not
anymore required by POSIX; instead, use the `dup2` syscall as a more
robust solution (conforms to POSIX.1).
Fixes: nodejs/help#2411
Refs: #875
PR-URL: #44461
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>dup2
1 parent 48cf890 commit 325254cCopy full SHA for 325254c
File tree
Expand file treeCollapse file tree
1 file changed
+23
-2
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
1 file changed
+23
-2
lines changedOpen diff view settings
Collapse file
+23-2Lines changed: 23 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
469 | 469 | |
470 | 470 | |
471 | 471 | |
| 472 | + |
472 | 473 | |
473 | 474 | |
474 | 475 | |
475 | | - |
476 | | - |
| 476 | + |
| 477 | + |
| 478 | + |
| 479 | + |
| 480 | + |
| 481 | + |
| 482 | + |
| 483 | + |
| 484 | + |
| 485 | + |
| 486 | + |
| 487 | + |
| 488 | + |
| 489 | + |
| 490 | + |
| 491 | + |
| 492 | + |
| 493 | + |
| 494 | + |
| 495 | + |
| 496 | + |
| 497 | + |
477 | 498 | |
478 | 499 | |
479 | 500 | |
|
0 commit comments