Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2c6a4fd

Browse filesBrowse files
santigimenodanielleadams
authored andcommitted
src: don't run tasks on isolate termination
Fixes: #45419 PR-URL: #45444 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 9c39b5e commit 2c6a4fd
Copy full SHA for 2c6a4fd

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎src/node_platform.cc‎

Copy file name to clipboardExpand all lines: src/node_platform.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ int NodePlatform::NumberOfWorkerThreads() {
406406
}
407407

408408
void PerIsolatePlatformData::RunForegroundTask(std::unique_ptr<Task> task) {
409-
if (isolate_->IsExecutionTerminating()) return task->Run();
409+
if (isolate_->IsExecutionTerminating()) return;
410410
DebugSealHandleScope scope(isolate_);
411411
Environment* env = Environment::GetCurrent(isolate_);
412412
if (env != nullptr) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.