Commit 1400796
net,tls: pass a valid socket on
On the 'tlsClientError' event, the `tlsSocket` instance is passed as
`closed` status. Thus, users can't get information such as `remote
address`, `remoteFamily`, and so on.
This adds a flag to close a socket after emitting an `error` event.
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #44021
Fixes: #43963
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>tlsClientError
1 parent e7d30b4 commit 1400796Copy full SHA for 1400796
File tree
Expand file treeCollapse file tree
3 files changed
+61
-7
lines changedOpen diff view settings
Filter options
- lib
- test/internet
Expand file treeCollapse file tree
3 files changed
+61
-7
lines changedOpen diff view settings
Collapse file
+4Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
424 | 424 | |
425 | 425 | |
426 | 426 | |
| 427 | + |
| 428 | + |
| 429 | + |
| 430 | + |
427 | 431 | |
428 | 432 | |
429 | 433 | |
|
Collapse file
+26-7Lines changed: 26 additions & 7 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
102 | 102 | |
103 | 103 | |
104 | 104 | |
| 105 | + |
105 | 106 | |
106 | 107 | |
107 | 108 | |
| ||
293 | 294 | |
294 | 295 | |
295 | 296 | |
| 297 | + |
| 298 | + |
| 299 | + |
| 300 | + |
| 301 | + |
| 302 | + |
| 303 | + |
| 304 | + |
| 305 | + |
| 306 | + |
| 307 | + |
| 308 | + |
| 309 | + |
296 | 310 | |
297 | 311 | |
298 | 312 | |
| ||
341 | 355 | |
342 | 356 | |
343 | 357 | |
| 358 | + |
344 | 359 | |
345 | 360 | |
346 | 361 | |
| ||
760 | 775 | |
761 | 776 | |
762 | 777 | |
| 778 | + |
| 779 | + |
| 780 | + |
| 781 | + |
763 | 782 | |
764 | | - |
765 | | - |
766 | | - |
767 | | - |
| 783 | + |
| 784 | + |
| 785 | + |
| 786 | + |
| 787 | + |
| 788 | + |
| 789 | + |
768 | 790 | |
769 | | - |
770 | | - |
771 | | - |
772 | 791 | |
773 | 792 | |
774 | 793 | |
|
Collapse file
test/internet/test-https-issue-43963.js
Copy file name to clipboard+31Lines changed: 31 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
| 25 | + |
| 26 | + |
| 27 | + |
| 28 | + |
| 29 | + |
| 30 | + |
| 31 | + |
0 commit comments