Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: return 403 when VPC-SC violation happens #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 2 commits into from
Feb 16, 2022
Merged

fix: return 403 when VPC-SC violation happens #1131

tswast merged 2 commits into from
Feb 16, 2022

Conversation

@Erroration2022
Copy link
Contributor

@Erroration2022 Erroration2022 commented Feb 4, 2022 •
edited
Loading

This is fixing the issue where VPC-SC violation is not returning 403. Error message map does not recognize VPCSC policy violation error and will default to return an internal server error.

@Erroration2022
fix: return 403 when VPC-SC violation happens
59e911c 
This is fixing the issue where VPC-SC violation is not returning 403. Error message map does not recognize VPCSC policy violation error and will default to return an internal server error.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Feb 4, 2022
@Erroration2022 Erroration2022 marked this pull request as ready for review February 4, 2022 17:46
@Erroration2022 Erroration2022 requested a review from a team February 4, 2022 17:46
@Erroration2022 Erroration2022 requested a review from a team as a code owner February 4, 2022 17:46
@shollyman shollyman requested a review from tswast February 5, 2022 22:35
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2022
@tswast
Copy link
Contributor

tswast commented Feb 8, 2022

Merging blocked by googleapis/google-resumable-media-python#297

@Erroration2022 Erroration2022 reopened this Feb 8, 2022
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2022
@tswast tswast merged commit f5daa9b into googleapis:main Feb 16, 2022
@release-please release-please bot mentioned this pull request Feb 16, 2022
Merged
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@Erroration2022 @tswast @abdelmegahedgoogle
fix: return 403 when VPC-SC violation happens (googleapis#1131)
d32a5a0 
This is fixing the issue where VPC-SC violation is not returning 403. Error message map does not recognize VPCSC policy violation error and will default to return an internal server error.

Co-authored-by: Tim Swast <swast@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Erroration2022 @tswast @yoshi-kokoro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.