Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add requires-network to pip requirements update. #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2023
Merged

Add requires-network to pip requirements update. #1050

merged 1 commit into from
Feb 8, 2023

Conversation

matts1
Copy link
Contributor

@matts1 matts1 commented Feb 8, 2023 •
edited
Loading

:requirements_test would previously fail if sandboxing was enabled.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@matts1
Add requires-network to pip requirements update.
e0b0e85 
:requirements_test would previously fail if sandboxing was enabled.
@matts1 matts1 requested a review from hrfuller as a code owner February 8, 2023 02:36
@f0rmiga f0rmiga merged commit 339c7e2 into bazel-contrib:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f0rmiga f0rmiga f0rmiga approved these changes

@hrfuller hrfuller Awaiting requested review from hrfuller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matts1 @f0rmiga
Morty Proxy This is a proxified and sanitized view of the page, visit original site.