Better description for pod_template_file
#16861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Airflow 2+, `pod_template_file` is the only way to configure workers, so we can remove the "other fields" language.
potiuk
approved these changes
Jul 8, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
approved these changes
Jul 11, 2021
josh-fell
pushed a commit
to josh-fell/airflow
that referenced
this pull request
Jul 19, 2021
In Airflow 2+, `pod_template_file` is the only way to configure workers, so we can remove the "other fields" language.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Airflow 2+,
pod_template_fileis the only way to configure workers,so we can remove the "other fields" language.
Also drop a link to the
pod_template_filesection for KubernetesExecutor viasee_also.Related: #16833