Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

delatrie
Copy link
Contributor

Context

Lazy-fixture is incompatible with pytest 8+ (see TvoroG/pytest-lazy-fixture#65 for more details). Because of this, our tests that check compatibility between allure-pytest and lazy-fixture fail (example: https://github.com/allure-framework/allure-python/actions/runs/7892006564/job/21537573652).

This PR marks those tests as tests with expected failure if they're run under pytest 8+. If the situation doesn't change, we might remove explicit support of lazy-fixture entirely in the future.

Additional changes

Disable pytest plugin autoload

All poe testing tasks now run pytest with plugin autoload disabled (via the PYTEST_DISABLE_PLUGIN_AUTOLOAD env var). The outer session doesn't need any. And if an inner session requires some plugins, they are always enabled explicitly by the runner.

@delatrie delatrie requested a review from skhomuti February 14, 2024 11:25
@delatrie delatrie marked this pull request as ready for review February 14, 2024 11:25
@delatrie delatrie merged commit fe74f46 into master Feb 15, 2024
@delatrie delatrie deleted the lazy-fixture-plugin-tests-xfail branch February 15, 2024 12:32
@delatrie delatrie added theme:pytest type:internal Change that isn't visible or obvious for end users labels Mar 11, 2024
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:pytest type:internal Change that isn't visible or obvious for end users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.