Dan Brown [Mon, 18 Jul 2022 12:18:46 +0000 (13:18 +0100)]
Made a bunch of tinymce 6 upgrade fixes
- Added workaround for new 'srcdoc' usage that's breaking content in
Firefox, added new 'custom-changes.md' file to document for future.
- Updated old usages of 'new' when creating nodes.
- Tested and changed logic, where required, where 'editor.dom.select'
has been used to replace the old '$' usages.
- Fixed bad boolean value being passed to 'setActive' in task list
logic.
Dan Brown [Sat, 16 Jul 2022 19:55:32 +0000 (20:55 +0100)]
Fixed a couple of non-intended logical permission issues
Both caught in tests:
Fixed loss of permissions for admin users when entity restrictions were
active, since there are no entity-restrictions for the admin role but
we'd force generate them in joint permissions, which would be queried.
Fixed new role permission checks when permissions given with only the
action (eg. 'view'), since the type prefix would be required for role
permission checks. Was previously not needed as only the simpler form
was used in the jointpermissions after merge & calculation.
Dan Brown [Sat, 16 Jul 2022 12:17:08 +0000 (13:17 +0100)]
Continued removal of joint permission non-view queries
Cleaned up PermissionApplicator to remove old cache system which was
hardly ever actuall caching anything since it was reset after each
public method run.
Changed the scope of 'userCanOnAny' to just check entity permissions,
and added protections of action scope creep, in case a role permission
action was passed by mistake.
Dan Brown [Wed, 13 Jul 2022 14:23:03 +0000 (15:23 +0100)]
Started removal of non-view permission queries
Updated ajax search and entity selector usage to display and handle
items that the user does not have permission to interact with.
Started logic changes to not allow permission type to be passed around,
with views instead being the fixed sole permission.
Dan Brown [Sat, 25 Jun 2022 12:55:57 +0000 (13:55 +0100)]
Fixed grid layouts being pushed out by child content
Ran a quick app run-thorugh in FireFox & Chrome, No secondary affects
immediately noticed but possible this could cause changes elsewhere due
to wide-spread grid item child targeting.
Dan Brown [Tue, 21 Jun 2022 14:32:18 +0000 (15:32 +0100)]
Review and update of login auto initiation PR
For PR #3406
- Updated naming from 'redirect' to 'initate/initation'.
- Updated phpunit.xml and .env.example.complete files with the new
option.
- Cleaned up controller logic a bit.
- Added content and design to the new initation view to not leave user
on a blank view for a while.
- Added non-JS button to initiation view as fallback option for
progression.
- Moved new test to it's own Test class and expanded with additional
scenario tests for better functionality coverage.
Dan Brown [Tue, 21 Jun 2022 11:01:06 +0000 (12:01 +0100)]
Fixed code snippets being added as single line
TinyMCE was adding attributes to <br> elements within code blocks which
would then not be converted to newlines by our code regex match.
This changes the conversion to use dom querying instead.
Dan Brown [Mon, 20 Jun 2022 22:47:42 +0000 (23:47 +0100)]
Fixed issue where text after line breaks not indexed
Linebreaks would previously essentially be removed during index and
hence joined to adjacent words, breaking prefix matching.
Added test to cover.
For #3508
Dan Brown [Wed, 15 Jun 2022 14:05:08 +0000 (15:05 +0100)]
Got book to shelf conversions working
- Also extracted shelf to book view elements to own partial.
- Fixed some existing logic including image param handling in update
request and activity logging against correct element.
Dan Brown [Mon, 13 Jun 2022 16:20:21 +0000 (17:20 +0100)]
Started work on hierachy conversion actions
- Updates book/shelf cover image handling for easier cloning/handling.
- Adds core logic for promoting books/chapters up a level.
- Enables usage of book/shelf cover image via API.
Dan Brown [Wed, 8 Jun 2022 16:56:59 +0000 (17:56 +0100)]
Reorganised and split out export templates & styles
Moved export templates elements into their own folder for better
grouping of logical usage.
Within the base export template, added some body classes to allow easier
targeted customisation via custom head css.
Split content of export templates into smaller partials for easier
future customization.
Dan Brown [Tue, 7 Jun 2022 15:07:28 +0000 (16:07 +0100)]
Updated markdown preview to update on diff-basis
Uses vdom system to diff and update the current markdown preview view
instead of requiring a full HTML replace change.
This should provide better performance, expecially where dynamically
loaded content such as iframes were in use.
Dan Brown [Tue, 7 Jun 2022 13:59:00 +0000 (14:59 +0100)]
Updated image drop handling to respect original file name
Now uses the previously timestamp gen name as a backup to the original
name. Aligns with the image manager upload which uses the original name
where given.
Dan Brown [Thu, 19 May 2022 16:38:04 +0000 (17:38 +0100)]
Updated attachment links to have dropdown for open type
- Allows easier accessibility of inline attachments.
- Introduces a new split-icon-list-item thingy to support such cases
where only part of the button is actually linked.
Dan Brown [Wed, 18 May 2022 13:06:40 +0000 (14:06 +0100)]
Made chapter toggle in book sidebar nav more consistent
- Now has a hover state to match other items.
- Now spans the full sidebar with like other items.
- Also updated chapter-toggle to a chapter-contents component, following
the newer component system.
Dan Brown [Wed, 18 May 2022 12:18:21 +0000 (13:18 +0100)]
Tweaked chapter list item styles
- Improves animation smoothness
- Changed animation slideup/down animations to use max-height instead of height
to better avoid jutter at the end.
- Cleaned spacing to match page items in books listing.
Dan Brown [Mon, 16 May 2022 13:05:21 +0000 (14:05 +0100)]
Fixed entity-specific tag counts listing
Was reporting wrong due to use of old polymorphic namespace references.
Test was not picking up as assertElementContains had wider scope than
expected, looking within the HTML of the element instead of the text
which you might expect. Updated test helper to look at text instead.
Dan Brown [Sat, 14 May 2022 15:05:29 +0000 (16:05 +0100)]
Improved input size consistency
Specifically updates dropdown search and user-search implementation,
although does affect all inputs.
Decouples breadcrum and select-style dropdown search toggles.
Dan Brown [Sat, 14 May 2022 12:55:03 +0000 (13:55 +0100)]
Updated tri-layout sidebars to not be cut-off by padding
Would cause effect where scroll area would be cut of by spacing which
looked a bit strange. This retains the same padding sizes but cuts the
content at the header or top of viewport.
Dan Brown [Sat, 14 May 2022 12:32:25 +0000 (13:32 +0100)]
Added animation transition for breadcrumb dropdown load
Animates the height on breadcrumb dropdown menus to transition to the
loaded animations quicker. Includes a new animation helper for doing
similar tasks in future.
Dan Brown [Sat, 14 May 2022 12:31:24 +0000 (13:31 +0100)]
Fixed loading animation delay
Loading animation would show in an unready state due to animation-delay
on components. Updated to a negative delay to ensure elements were in
correct positions right away upon show.
Dan Brown [Sat, 14 May 2022 12:11:48 +0000 (13:11 +0100)]
Updated breadcrumb dropdown styles, improved keyboard nav
- Removed harsh theme color border between search and content.
- Prevented intermediate focus on list container to align arrow & tab
behaviour, and to get to content quicker.