]> BookStack Code Mirror - bookstack/log
bookstack
17 months agoMerge branch 'development' into default-templates
Dan Brown [Mon, 11 Dec 2023 11:41:43 +0000 (11:41 +0000)]
Merge branch 'development' into default-templates

17 months agoPHPStan: Fixed larastan loading and address some level2 issues
Dan Brown [Sun, 10 Dec 2023 14:58:05 +0000 (14:58 +0000)]
PHPStan: Fixed larastan loading and address some level2 issues

17 months agoURL Handling: Removed referrer-based redirect handling
Dan Brown [Sun, 10 Dec 2023 12:37:21 +0000 (12:37 +0000)]
URL Handling: Removed referrer-based redirect handling

Swapped back handling to instead be pre-determined instead of being
based upon session/referrer which would cause inconsistent results when
referrer data was not available (redirect to app-loaded images/files).

To support, this adds a mechansism to provide a URL through request
data.

Also cleaned up some imports in code while making changes.
Closes #4656.

18 months agoDepenencies: Updated NPM packages
Dan Brown [Sat, 9 Dec 2023 10:49:28 +0000 (10:49 +0000)]
Depenencies: Updated NPM packages

Avoided updating markdown-it package to 14 for now since it would cause
bundle size to inflate. Don't think ESBuild is properly tree shaking
"entities" sub package which inflates size.

18 months agoDependencies: Updated composer PHP deps
Dan Brown [Sat, 9 Dec 2023 10:05:23 +0000 (10:05 +0000)]
Dependencies: Updated composer PHP deps

18 months agoSAML2: Fixed non-spec point of logout, Improved redirect location
Dan Brown [Fri, 8 Dec 2023 18:38:52 +0000 (18:38 +0000)]
SAML2: Fixed non-spec point of logout, Improved redirect location

This changes the point-of-logout to be within the initial part of the
SAML logout flow, as per 5.3.2 of the SAML spec, processing step 2.
This also improves the logout redirect handling to use the global
redirect suggestion so that auto-login handling is properly taken into
account.

Added tests to cover.
Manual testing performed against keycloak.
For #4713

18 months agoMerge pull request #4714 from BookStackApp/oidc_logout
Dan Brown [Thu, 7 Dec 2023 18:00:32 +0000 (18:00 +0000)]
Merge pull request #4714 from BookStackApp/oidc_logout

OIDC RP-Initiated logout

18 months agoOIDC: Update example env option to reflect correct default 4714/head
Dan Brown [Thu, 7 Dec 2023 17:59:48 +0000 (17:59 +0000)]
OIDC: Update example env option to reflect correct default

18 months agoOIDC RP Logout: Fixed issues during testing
Dan Brown [Thu, 7 Dec 2023 17:45:17 +0000 (17:45 +0000)]
OIDC RP Logout: Fixed issues during testing

- Disabled by default due to strict rejection by auth systems.
- Fixed issue when autoloading logout URL, but not provided in
  autodiscovery response.
- Added proper handling for if the logout URL contains a query string
  already.
- Added extra tests to cover.
- Forced config endpoint to be used, if set as a string, instead of
  autodiscovery endpoint.

18 months agoTests: Fixed debug test to work with social class changes
Dan Brown [Wed, 6 Dec 2023 16:57:15 +0000 (16:57 +0000)]
Tests: Fixed debug test to work with social class changes

18 months agoOIDC RP Logout: Added autodiscovery support and test cases
Dan Brown [Wed, 6 Dec 2023 16:41:50 +0000 (16:41 +0000)]
OIDC RP Logout: Added autodiscovery support and test cases

18 months agoAuth: Refactored OIDC RP-logout PR code, Extracted logout
Dan Brown [Wed, 6 Dec 2023 13:49:53 +0000 (13:49 +0000)]
Auth: Refactored OIDC RP-logout PR code, Extracted logout

Extracted logout to the login service so the logic can be shared instead
of re-implemented at each stage. For this, the SocialAuthService was
split so the driver management is in its own class, so it can be used
elsewhere without use (or circular dependencies) of the
SocialAuthService.

During review of #4467

18 months agoMerge branch 'fix/oidc-logout' into development
Dan Brown [Wed, 6 Dec 2023 12:14:43 +0000 (12:14 +0000)]
Merge branch 'fix/oidc-logout' into development

18 months agoRTL: Made a range of fixes & improvments for RTL text
Dan Brown [Tue, 5 Dec 2023 18:53:48 +0000 (18:53 +0000)]
RTL: Made a range of fixes & improvments for RTL text

- Updated HTML exports to have auto direction to properly react to RTL
  text when in the content.
- Fixed RTL spacing issues in new editor design changes.
- Fixed pointer arrow being angled wrong on RTL languages.

Related to #4645

18 months agoSAML2: Included parsed groups in dump data
Dan Brown [Sun, 3 Dec 2023 19:35:05 +0000 (19:35 +0000)]
SAML2: Included parsed groups in dump data

Updated code style of class while there.
Removed redundant check and string translation used.

For #4706

18 months agoMerge branch 'v23-10' into development
Dan Brown [Sun, 3 Dec 2023 18:57:07 +0000 (18:57 +0000)]
Merge branch 'v23-10' into development

18 months agoMerge pull request #4688 from BookStackApp/include-parser
Dan Brown [Mon, 27 Nov 2023 21:54:18 +0000 (21:54 +0000)]
Merge pull request #4688 from BookStackApp/include-parser

New include tag parser

18 months agoIncludes: Added back support for parse theme event 4688/head
Dan Brown [Mon, 27 Nov 2023 21:38:43 +0000 (21:38 +0000)]
Includes: Added back support for parse theme event

Managed to do this in an API-compatible way although resuling output may
differ due to new dom handling in general, although user content is used
inline to remain as comptable as possible.

18 months agoIncludes: Added ID de-duplicating and more thorough clean-up
Dan Brown [Mon, 27 Nov 2023 20:16:27 +0000 (20:16 +0000)]
Includes: Added ID de-duplicating and more thorough clean-up

18 months agoIncludes: Switched page to new system
Dan Brown [Mon, 27 Nov 2023 19:54:47 +0000 (19:54 +0000)]
Includes: Switched page to new system

- Added mulit-level depth parsing.
- Updating usage of HTML doc in page content to be efficient.
- Removed now redundant PageContentTest cases.
- Made some include system fixes based upon testing.

18 months agoIncludes: Updated logic regarding parent block els, added tests
Dan Brown [Sat, 25 Nov 2023 17:32:00 +0000 (17:32 +0000)]
Includes: Updated logic regarding parent block els, added tests

Expanded tests with many more cases, and added fixes for failed
scenarios.
Updated logic to specifically handling parent <p> tags, and now assume
compatibility with parent block types elswhere to allow use in a
variety of scenarios (td, details, blockquote etc...).

18 months agoIncludes: Added block-level handling to new include system
Dan Brown [Fri, 24 Nov 2023 23:39:16 +0000 (23:39 +0000)]
Includes: Added block-level handling to new include system

Implements block promoting to body (including position choosing based
upon likely tag position within parent) and block splitting where we're
only a single depth down from the body child.

18 months agoIncludes: Developed to get new system working with inline includes
Dan Brown [Thu, 23 Nov 2023 14:29:07 +0000 (14:29 +0000)]
Includes: Developed to get new system working with inline includes

Adds logic for locating and splitting text nodes.
Adds specific classes to offload tag/content specific logic.

18 months agoIncludes: Started foundations for new include tag parser
Dan Brown [Wed, 22 Nov 2023 22:14:28 +0000 (22:14 +0000)]
Includes: Started foundations for new include tag parser

18 months agoImages: Prevented base64 extraction without permission 4684/head
Dan Brown [Mon, 20 Nov 2023 13:32:31 +0000 (13:32 +0000)]
Images: Prevented base64 extraction without permission

Also added content sniffing as an extra check.
Added tests to cover.

18 months agoImages: Forced intervention loading via specific method
Dan Brown [Sun, 19 Nov 2023 16:34:29 +0000 (16:34 +0000)]
Images: Forced intervention loading via specific method

Updated image loading for intervention library to be via a specific
'initFromBinary' method to avoid being overly accepting of input types
and mechansisms.

For CVE-2023-6199

18 months agoFavicon: Moved resizing to specific resizer class
Dan Brown [Sun, 19 Nov 2023 15:57:19 +0000 (15:57 +0000)]
Favicon: Moved resizing to specific resizer class

18 months agoLogicalTheme: Added events for registering web routes
Dan Brown [Fri, 17 Nov 2023 13:45:57 +0000 (13:45 +0000)]
LogicalTheme: Added events for registering web routes

Added to allow easier registration of routes.
Added for normal web and authed routes.
Included testing to cover.

18 months agoHTML: Tweaked output from full HtmlDocument
Dan Brown [Tue, 14 Nov 2023 17:23:05 +0000 (17:23 +0000)]
HTML: Tweaked output from full HtmlDocument

Saves specifically the document element on output to HTML, since this
results in just the outer HTML being saved while not including the extra
XML tags which would show up before with the changes to force utf8
usage.

18 months agoMerge pull request #4673 from BookStackApp/html_doc_alignment
Dan Brown [Tue, 14 Nov 2023 17:22:30 +0000 (17:22 +0000)]
Merge pull request #4673 from BookStackApp/html_doc_alignment

HTML: Aligned and standardised DOMDocument usage

18 months agoHTML: Aligned and standardised DOMDocument usage 4673/head
Dan Brown [Tue, 14 Nov 2023 15:46:32 +0000 (15:46 +0000)]
HTML: Aligned and standardised DOMDocument usage

Adds a thin wrapper for DOMDocument to simplify and align usage within
all areas of BookStack.
Also means we move away from old depreacted mb_convert_encoding usage.

Closes #4638

18 months agoMerge pull request #4661 from BookStackApp/tinymce_update
Dan Brown [Tue, 14 Nov 2023 13:15:32 +0000 (13:15 +0000)]
Merge pull request #4661 from BookStackApp/tinymce_update

WYSIWYG: Updated TinyMCE from 6.5.1 to 6.7.2

18 months agoMerge branch 'Man-in-Black-patch-1' into development
Dan Brown [Tue, 14 Nov 2023 10:40:30 +0000 (10:40 +0000)]
Merge branch 'Man-in-Black-patch-1' into development

18 months agoNotifications: Review of PR to include path path #4629
Dan Brown [Tue, 14 Nov 2023 10:31:44 +0000 (10:31 +0000)]
Notifications: Review of PR to include path path #4629

- Merged book and chapter name items to a single page path list item
  which has links to parent page/chapter.
- Added permission filtering to page path elements.
- Added page path to also be on comment notifications.
- Updated testing to cover.
- Added new Message Line objects to support.

Done during review of #4629

18 months agoAdded book name to the mail template
Sascha [Thu, 26 Oct 2023 12:01:38 +0000 (14:01 +0200)]
Added book name to the mail template

added book name

synced with actual file from dev branch

added book name

add book name

added book name

extended with chaptername

extended with chapter name

Update PageUpdateNotification.php

Update notifications.php

Update notifications.php

Update notifications.php

correction of chapter syntax

correction of chapter syntax

18 months agoJS: Removed random extra import
Dan Brown [Thu, 9 Nov 2023 13:36:00 +0000 (13:36 +0000)]
JS: Removed random extra import

18 months agoWYSIWYG: Updated TinyMCE from 6.5.1 to 6.7.2 4661/head
Dan Brown [Thu, 9 Nov 2023 13:34:00 +0000 (13:34 +0000)]
WYSIWYG: Updated TinyMCE from 6.5.1 to 6.7.2

19 months agoUpdated translator attribution before release v23.10.2
Dan Brown [Tue, 7 Nov 2023 15:12:15 +0000 (15:12 +0000)]
Updated translator attribution before release v23.10.2

19 months agoMerge branch 'development' of github.com:BookStackApp/BookStack into development
Dan Brown [Tue, 7 Nov 2023 15:09:54 +0000 (15:09 +0000)]
Merge branch 'development' of github.com:BookStackApp/BookStack into development

19 months agoDropdowns: Fixed bad direction logic, added dynmaic height
Dan Brown [Tue, 7 Nov 2023 15:07:11 +0000 (15:07 +0000)]
Dropdowns: Fixed bad direction logic, added dynmaic height

Changes since adding notifications would cause direction to be assessed
upon max height of 80vh, which caused large dropdowns like the audit log
dropdown to drop up and/or go offscreen.
This restores the default assessment of 500px, and adds dynamic
max-height adjustment to provide more room for large dropdowns.

For #4652

19 months agoUpdated translations with latest Crowdin changes (#4643)
Dan Brown [Tue, 7 Nov 2023 14:40:53 +0000 (14:40 +0000)]
Updated translations with latest Crowdin changes (#4643)

19 months agoPWA: Prevent passing credentials to avoid redirection issues
Dan Brown [Tue, 7 Nov 2023 14:33:37 +0000 (14:33 +0000)]
PWA: Prevent passing credentials to avoid redirection issues

For #4649
More of a patch around the issue for now.
Have opened #4656 to properly address.

19 months agoUpdated translations with latest Crowdin changes (#4631)
Dan Brown [Thu, 2 Nov 2023 14:30:34 +0000 (14:30 +0000)]
Updated translations with latest Crowdin changes (#4631)

19 months agoLangs: Enabled Nynorsk option, updated translator attribution
Dan Brown [Thu, 2 Nov 2023 14:17:56 +0000 (14:17 +0000)]
Langs: Enabled Nynorsk option, updated translator attribution

19 months agoMD Editor: Fixed lack of toolbar BG when in fullscreen
Dan Brown [Thu, 2 Nov 2023 12:41:07 +0000 (12:41 +0000)]
MD Editor: Fixed lack of toolbar BG when in fullscreen

For #4641

19 months agoEditor toolbox: Updated tabs to use link color
Dan Brown [Thu, 2 Nov 2023 12:34:57 +0000 (12:34 +0000)]
Editor toolbox: Updated tabs to use link color

Change due to link color being more suitable in this case since it's not
specifically a block with light text which is what app color is suited
for.
Specifically better for dark mode when a dark app color is used.

For #4630

19 months agoPage JS: Improved block jumping and highlighting
Dan Brown [Wed, 1 Nov 2023 18:49:47 +0000 (18:49 +0000)]
Page JS: Improved block jumping and highlighting

- Updated anchor scroll change to open up details blocks if the target
  exists within.
- Updated highlighting and animation implementation to fix hardly visible highlighting.
- Removed old, now unused, handing of CM instances in details blocks.

Related to #4637.

19 months agoJS Events: Added CM pre/post init events
Dan Brown [Wed, 1 Nov 2023 17:56:52 +0000 (17:56 +0000)]
JS Events: Added CM pre/post init events

To allow hacking of all CodeMirror instances.
Closes #4639.

19 months agoTesting: Added PHP8.3 support
Dan Brown [Tue, 31 Oct 2023 15:50:56 +0000 (15:50 +0000)]
Testing: Added PHP8.3 support

Also fixed text which could through deprecation notice due to not having
a properly formed comment in use.
For #4633

19 months agoReadme: Updated sponsorship links and language contribution info
Dan Brown [Mon, 30 Oct 2023 17:13:39 +0000 (17:13 +0000)]
Readme: Updated sponsorship links and language contribution info

- Updated sponsor text since it only mentioned GitHub, nothing else.
- Updated translation contribution info to dissuade code-based
  contributions due to issues with conflicts/sync.

19 months agoDemo mode: Updated my account access to be more selective
Dan Brown [Mon, 30 Oct 2023 12:07:18 +0000 (12:07 +0000)]
Demo mode: Updated my account access to be more selective

19 months agoLangs: Updated translators and locale list pre v23.10
Dan Brown [Mon, 30 Oct 2023 11:41:36 +0000 (11:41 +0000)]
Langs: Updated translators and locale list pre v23.10

19 months agoUpdated translations with latest Crowdin changes (#4523)
Dan Brown [Mon, 30 Oct 2023 11:16:19 +0000 (11:16 +0000)]
Updated translations with latest Crowdin changes (#4523)

19 months agoMiddlware: Prevented caching of all app requests
Dan Brown [Mon, 23 Oct 2023 12:32:15 +0000 (13:32 +0100)]
Middlware: Prevented caching of all app requests

Previously we'd prevent caching of authed responses for security
(prevent back cache or proxy caching) but caching could still be an
issue in non-auth scenarios due to CSRF (eg. returning to login screen after
session expiry).

For #4600

19 months agoStyles: Aligned empty state alignment & consistency
Dan Brown [Mon, 23 Oct 2023 10:53:19 +0000 (11:53 +0100)]
Styles: Aligned empty state alignment & consistency

- Fixed inital empty state margins/paddings to be aligned and not differ
when lists are empty.
- Aligned button/action display when viewing empty entities.
- Fixed use of non-existing permission in books for book empty state
  button.

Fixes #4563

19 months agoShortcuts: Prevented help shown when in inputs
Dan Brown [Mon, 23 Oct 2023 10:04:09 +0000 (11:04 +0100)]
Shortcuts: Prevented help shown when in inputs

For #4606

19 months agoDeps: Updated npm and composer packages
Dan Brown [Fri, 20 Oct 2023 15:39:40 +0000 (16:39 +0100)]
Deps: Updated npm and composer packages

19 months agoSecurity: Swapped twitter for mastodon link
Dan Brown [Thu, 19 Oct 2023 15:53:02 +0000 (16:53 +0100)]
Security: Swapped twitter for mastodon link

19 months agoMerge pull request #4618 from radiantwave/patch-1
Dan Brown [Thu, 19 Oct 2023 15:50:30 +0000 (16:50 +0100)]
Merge pull request #4618 from radiantwave/patch-1

Remove huntr from SECURITY.md

19 months agoMerge pull request #4615 from BookStackApp/user_account
Dan Brown [Thu, 19 Oct 2023 15:49:06 +0000 (16:49 +0100)]
Merge pull request #4615 from BookStackApp/user_account

User preferences/options cleanup

19 months agoMy Acount: Updated old preference url reference for watches 4615/head
Dan Brown [Thu, 19 Oct 2023 15:37:55 +0000 (16:37 +0100)]
My Acount: Updated old preference url reference for watches

19 months agoUpdate SECURITY.md 4618/head
Daniel [Thu, 19 Oct 2023 15:12:18 +0000 (17:12 +0200)]
Update SECURITY.md

Remove huntr

19 months agoMy Account: Covered profile and auth pages with tests
Dan Brown [Thu, 19 Oct 2023 15:06:59 +0000 (16:06 +0100)]
My Account: Covered profile and auth pages with tests

19 months agoUser Account: Ensured page titles for pages and api tokens
Dan Brown [Thu, 19 Oct 2023 14:24:48 +0000 (15:24 +0100)]
User Account: Ensured page titles for pages and api tokens

19 months agoMy Account: Updated and started adding to tests
Dan Brown [Thu, 19 Oct 2023 13:18:42 +0000 (14:18 +0100)]
My Account: Updated and started adding to tests

- Updated existing tests now affected by my-account changes.
- Updated some existing tests to more accuractly check the scenario.
- Updated some code styling in SocialController.
- Fixed redirects for social account flows to fit my-account.
- Added test for social account attaching.
- Added test for api token redirect handling.

19 months agoAPI Tokens: Updated interfaces to return to correct location
Dan Brown [Thu, 19 Oct 2023 10:31:45 +0000 (11:31 +0100)]
API Tokens: Updated interfaces to return to correct location

Since management of API tokens can be accessed via two routes, this adds
tracking and handling to reutrn the user to the correct place.

19 months agoMy Account: Added self-delete flow
Dan Brown [Thu, 19 Oct 2023 09:48:27 +0000 (10:48 +0100)]
My Account: Added self-delete flow

19 months agoUser form: Always show external auth field, update access control
Dan Brown [Thu, 19 Oct 2023 09:20:04 +0000 (10:20 +0100)]
User form: Always show external auth field, update access control

Updated old user management routes to only be accessible with permission
to manage users, so also removed old content controls checking for that
permission.

19 months agoMy Account: Cleaned-up/reorganised user header dropdown
Dan Brown [Wed, 18 Oct 2023 16:57:14 +0000 (17:57 +0100)]
My Account: Cleaned-up/reorganised user header dropdown

19 months agoMy Account: Extracted/tweaked profile text, removed old index
Dan Brown [Wed, 18 Oct 2023 16:53:58 +0000 (17:53 +0100)]
My Account: Extracted/tweaked profile text, removed old index

19 months agoMy Account: Built out profile page & endpoints
Dan Brown [Wed, 18 Oct 2023 11:39:57 +0000 (12:39 +0100)]
My Account: Built out profile page & endpoints

Text currently hard-coded, needs finalising and extracting.

19 months agoUsers: Built out auth page for my-account section
Dan Brown [Tue, 17 Oct 2023 16:38:07 +0000 (17:38 +0100)]
Users: Built out auth page for my-account section

19 months agoUser: Started cleanup of user self-management
Dan Brown [Tue, 17 Oct 2023 12:11:10 +0000 (13:11 +0100)]
User: Started cleanup of user self-management

- Moved preference views to more general "my-account" area.
- Started new layout for my-account with sidebar.
- Added MFA to prefeences view (to be moved).

19 months agoMerge pull request #4604 from BookStackApp/editor_trim_enhancement
Dan Brown [Sat, 14 Oct 2023 16:30:04 +0000 (17:30 +0100)]
Merge pull request #4604 from BookStackApp/editor_trim_enhancement

Editor design update

19 months agoEditors: Properly aligned edit area border radius 4604/head
Dan Brown [Sat, 14 Oct 2023 16:18:09 +0000 (17:18 +0100)]
Editors: Properly aligned edit area border radius

19 months agoEditors: Adjusted new design for mobile and dark mode
Dan Brown [Sat, 14 Oct 2023 16:10:07 +0000 (17:10 +0100)]
Editors: Adjusted new design for mobile and dark mode

Tested new design across FF, Chrome, and Gnome web (webkit)

19 months agoEditors: Tightened up new design, adjusted for MD editor
Dan Brown [Sat, 14 Oct 2023 15:33:48 +0000 (16:33 +0100)]
Editors: Tightened up new design, adjusted for MD editor

19 months agoEditor: Started toying with more singificant design update
Dan Brown [Fri, 13 Oct 2023 16:33:11 +0000 (17:33 +0100)]
Editor: Started toying with more singificant design update

20 months agoEditor: Started attempts to improve design elements
Dan Brown [Sun, 8 Oct 2023 14:04:07 +0000 (15:04 +0100)]
Editor: Started attempts to improve design elements

20 months agoHomepage: Made much nicer at ipad-like widths
Dan Brown [Sat, 7 Oct 2023 11:38:54 +0000 (12:38 +0100)]
Homepage: Made much nicer at ipad-like widths

Updated default homepage layout to be much nicer at ipad-like widths by
switching to css-column approach at those breakpoints.
Also neated top actions by switching to simpler flexbox layout.

Fixes #4596

20 months agoMerge branch 'LawssssCat/development' into development
Dan Brown [Fri, 6 Oct 2023 11:01:18 +0000 (12:01 +0100)]
Merge branch 'LawssssCat/development' into development

20 months agoLayout: Restructured tri-layout for sidebar control
Dan Brown [Fri, 6 Oct 2023 10:57:55 +0000 (11:57 +0100)]
Layout: Restructured tri-layout for sidebar control

Restructured tri-layout grid system, so the sidebars are contained in
their own child grid system, mimicking the parent grid, so we can treat
them as part of the same parent scroll container at smaller screen
sizes for consistent scroll/sticky behavior.

Tested on Firefox, Chromium, Gnome Web and Safari (MacOS).

For #4394
Changes made during review of #4562

20 months agoCI: Added path filtering to actions
Dan Brown [Wed, 4 Oct 2023 08:18:24 +0000 (09:18 +0100)]
CI: Added path filtering to actions

In the hope we can make the CI runs a bit more efficient and energy
conscious, by only running when relevant files have changed.

20 months agoTags: Fixed enter press clearing field
Dan Brown [Wed, 4 Oct 2023 08:08:10 +0000 (09:08 +0100)]
Tags: Fixed enter press clearing field

For #4570

20 months agoPrint Styles: Removed use of seperate style sheet
Dan Brown [Tue, 3 Oct 2023 14:12:23 +0000 (15:12 +0100)]
Print Styles: Removed use of seperate style sheet

Seemed a bit redundant and complicated, since we're only adding a few
extra styles. Just merged into main styles instead.

20 months agoPrint Styles: Fixed header/footer content showing
Dan Brown [Tue, 3 Oct 2023 13:59:35 +0000 (14:59 +0100)]
Print Styles: Fixed header/footer content showing

Extra bits were showing due to recent changes.
Done a quick pass through major display views.

Fixes #4594

20 months agoTesting: Added favicon cleanup
Dan Brown [Tue, 3 Oct 2023 13:50:54 +0000 (14:50 +0100)]
Testing: Added favicon cleanup

Was leaving a changed favicon leaving other test to fail.

20 months agoAdded NETWAYS to readme sponsor list
Dan Brown [Tue, 3 Oct 2023 11:10:45 +0000 (12:10 +0100)]
Added NETWAYS to readme sponsor list

Related to:
https://github.com/BookStackApp/website/commit/edceda5342a95bba1e95abae55a5d62dc1ba6e45

20 months agoMerge branch 'basic-pwa-support' into development
Dan Brown [Mon, 2 Oct 2023 14:58:07 +0000 (15:58 +0100)]
Merge branch 'basic-pwa-support' into development

20 months agoPWA Manifest: Tweaks during review of PR #4430
Dan Brown [Mon, 2 Oct 2023 14:54:39 +0000 (15:54 +0100)]
PWA Manifest: Tweaks during review of PR #4430

- Updated to go through HomeController with the builder as a helper
  class.
- Extracted some reapeated items into variables in manifest.
- Updated background color to match those used by BookStack.
- Removed reference of icon.ico since its not intended to be used.
- Added tests to cover functionality.

Review of #4430

20 months agoMerge pull request #4578 from BookStackApp/upload_handling
Dan Brown [Sun, 1 Oct 2023 17:20:10 +0000 (17:20 +0000)]
Merge pull request #4578 from BookStackApp/upload_handling

Improvements to file/image upload handling UX

20 months agoJS: Fixed ESLint issues 4578/head
Dan Brown [Sun, 1 Oct 2023 17:13:54 +0000 (18:13 +0100)]
JS: Fixed ESLint issues

20 months agoImages: Rolled out image memory handling to image actions
Dan Brown [Sun, 1 Oct 2023 12:05:18 +0000 (13:05 +0100)]
Images: Rolled out image memory handling to image actions

- Moved thumnbail loading out of repo into ImageResizer.
- Updated gallery and editor image handling to show errors where
  possible to indicate memory issues for resizing/thumbs.
- Updated gallery to load image data in a per-image basis via edit form
  for more resiliant thumb/data fetching. Data was previously provided
  via gallery listing, which could be affected by failing generation
  of other images.
- Updated image manager double click handling to be more pleasant and
  not flash away the edit form.
- Updated editor handlers to use main URL when thumbs fail to load.

20 months agoImages: Extracted out image resizing to its own class
Dan Brown [Sat, 30 Sep 2023 19:00:48 +0000 (20:00 +0100)]
Images: Extracted out image resizing to its own class

20 months agoImages: Added thin wrapper around image filesystem instances
Dan Brown [Sat, 30 Sep 2023 18:12:22 +0000 (19:12 +0100)]
Images: Added thin wrapper around image filesystem instances

Extracts duplicated required handling (Like path adjustment) out to
simpler storage disk instance which can be passed around.

20 months agoImages: Started refactor of image service
Dan Brown [Sat, 30 Sep 2023 17:28:42 +0000 (18:28 +0100)]
Images: Started refactor of image service

To break it up.
Also added better memory handling to other parts of the app.

20 months agoImage manager: Tweaked grid sizing to prevent massive items
Dan Brown [Sat, 30 Sep 2023 11:43:51 +0000 (12:43 +0100)]
Image manager: Tweaked grid sizing to prevent massive items

20 months agoImages: Added test to cover thubmnail regen endpoint
Dan Brown [Sat, 30 Sep 2023 11:29:49 +0000 (12:29 +0100)]
Images: Added test to cover thubmnail regen endpoint

20 months agoImages: Reverted some thumbnails to be on-demand generated
Dan Brown [Sat, 30 Sep 2023 11:09:29 +0000 (12:09 +0100)]
Images: Reverted some thumbnails to be on-demand generated

Added since we can't always be sure of future image usage, and in many
cases we don't generate ahead-of-time.
Also:
- Simplified image handling on certain models.
- Updated various string handling operations to use newer functions.

20 months agoThumbnails: Added OOM handling and regen endpoint
Dan Brown [Fri, 29 Sep 2023 12:54:08 +0000 (13:54 +0100)]
Thumbnails: Added OOM handling and regen endpoint

- Added some level of app out-of-memory handling so we can show a proper
  error message upon OOM events.
- Added endpoint and image-manager button/action for regenerating
  thumbnails for an image so they can be re-created upon failure.

Morty Proxy This is a proxified and sanitized view of the page, visit original site.