]> BookStack Code Mirror - bookstack/commit
projects / bookstack / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 8da3e64)
Increased attachment link limit from 192 to 2k
authorDan Brown <redacted>
Mon, 20 Feb 2023 13:05:23 +0000 (13:05 +0000)
committerDan Brown <redacted>
Mon, 20 Feb 2023 13:05:23 +0000 (13:05 +0000)
commitc80396136f1f34dce643ff5649e74e67449e6f78
treebcb3a48be404d46fa04d91fa19d7a28ece278da2tree | snapshot
parent8da3e64039481ef5b02dd158c588fbaf2523cb27commit | diff
Increased attachment link limit from 192 to 2k

Added test to cover.
Did attempt a 64k limit, but values over 2k significantly increase
chance of other issues since this URL may be used in redirect headers.
Would rather catch issues in-app.

For #4044
app/Http/Controllers/Api/AttachmentApiController.php diff | blob | history
app/Http/Controllers/AttachmentController.php diff | blob | history
app/Providers/ValidationRuleServiceProvider.php diff | blob | history
app/Uploads/Attachment.php diff | blob | history
database/migrations/2023_02_20_093655_increase_attachments_path_length.php [new file with mode: 0644] blob
tests/Uploads/AttachmentTest.php diff | blob | history
The core source code for the BookStack project.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.