]> BookStack Code Mirror - bookstack/commit
Tweaked LDAP TLS Implementation
authorDan Brown <redacted>
Sun, 7 Feb 2021 20:00:04 +0000 (20:00 +0000)
committerDan Brown <redacted>
Sun, 7 Feb 2021 20:00:04 +0000 (20:00 +0000)
commitaf032f89932290b9f1217e80733447da6c039f55
tree0ab1d56a270272be2d338636c991479dff36ca0f
parentf177b02cae093ee836ba1e6ed3c8ac9ddf221167
Tweaked LDAP TLS Implementation

- Moved the ldap function out to our separate service for easier
  testing.
- Added testing for the option.
- Moved tls_insecure part back up above connection start as found more
  reliable there.

Done a lot of real-connection testing during this review.
Used wireshare to ensure TLS connection does take place.
Found LDAP_TLS_INSECURE=false can action unreliably, restarting php-fpm
helped.
Tested both trusted and untrusted certificates.
app/Auth/Access/Ldap.php
app/Auth/Access/LdapService.php
phpunit.xml
tests/Auth/LdapTest.php
Morty Proxy This is a proxified and sanitized view of the page, visit original site.