]> BookStack Code Mirror - bookstack/commit
Continued review of #2169
authorDan Brown <redacted>
Wed, 6 Oct 2021 22:05:26 +0000 (23:05 +0100)
committerDan Brown <redacted>
Wed, 6 Oct 2021 22:05:26 +0000 (23:05 +0100)
commit41438adbd1dbe8688ff8ff7d3dbb835d1e9650e1
tree764de643bd97d8ab06ad16b58436016471b9ddac
parent2ec0aa85cab7c09f45589af6b05a053d44a8ca46
Continued review of #2169

- Removed uneeded custom refresh or logout actions for OIDC.
- Restructured how the services and guards are setup for external auth
  systems. SAML2 and OIDC now directly share a lot more logic.
- Renamed any OpenId references to OIDC or OpenIdConnect
- Removed non-required CSRF excemption for OIDC

Not tested, Come to roadblock due to lack of PHP8 support in upstream
dependancies. Certificate was deemed to be non-valid on every test
attempt due to changes in PHP8.
24 files changed:
app/Auth/Access/GroupSyncService.php [moved from app/Auth/Access/ExternalAuthService.php with 63% similarity]
app/Auth/Access/Guards/AsyncExternalBaseSessionGuard.php [moved from app/Auth/Access/Guards/Saml2SessionGuard.php with 92% similarity]
app/Auth/Access/Guards/OpenIdSessionGuard.php [deleted file]
app/Auth/Access/LdapService.php
app/Auth/Access/OpenIdConnectService.php [new file with mode: 0644]
app/Auth/Access/OpenIdService.php [deleted file]
app/Auth/Access/RegistrationService.php
app/Auth/Access/Saml2Service.php
app/Config/auth.php
app/Exceptions/OpenIdConnectException.php [new file with mode: 0644]
app/Exceptions/OpenIdException.php [deleted file]
app/Http/Controllers/Auth/OpenIdConnectController.php [new file with mode: 0644]
app/Http/Controllers/Auth/OpenIdController.php [deleted file]
app/Http/Middleware/VerifyCsrfToken.php
app/Providers/AuthServiceProvider.php
resources/icons/oidc.svg [new file with mode: 0644]
resources/lang/en/errors.php
resources/views/auth/parts/login-form-oidc.blade.php [new file with mode: 0644]
resources/views/auth/parts/login-form-openid.blade.php [deleted file]
resources/views/common/header.blade.php
resources/views/settings/index.blade.php
resources/views/settings/roles/parts/form.blade.php
resources/views/users/parts/form.blade.php
routes/web.php
Morty Proxy This is a proxified and sanitized view of the page, visit original site.