]> BookStack Code Mirror - bookstack/commit
Reviewed and added testing for BookShelf API implementation
authorDan Brown <redacted>
Fri, 10 Apr 2020 14:19:18 +0000 (15:19 +0100)
committerDan Brown <redacted>
Fri, 10 Apr 2020 14:19:18 +0000 (15:19 +0100)
commit29705a25cee61d9c063e0f102cd018557aec5abd
treece7745cd200178e820ed81a9c02743a6ec388eb1
parentda1cea06ca5db56a9635bf8bb01da2516d601620
Reviewed and added testing for BookShelf API implementation

- Tweaked how books are passed on update to prevent unassignment if
parameter is not provided.
- Added books to validation so they show in docs.
- Added request/response examples.
- Added tests to cover.
- Added child book info to shelf info.

Review of #1908
13 files changed:
app/Auth/User.php
app/Entities/Book.php
app/Entities/Bookshelf.php
app/Entities/Repos/BookshelfRepo.php
app/Http/Controllers/Api/BookshelfApiController.php
dev/api/requests/shelves-create.json [new file with mode: 0644]
dev/api/requests/shelves-update.json [new file with mode: 0644]
dev/api/responses/books-read.json
dev/api/responses/shelves-create.json [new file with mode: 0644]
dev/api/responses/shelves-list.json [new file with mode: 0644]
dev/api/responses/shelves-read.json [new file with mode: 0644]
dev/api/responses/shelves-update.json [new file with mode: 0644]
tests/Api/ShelvesApiTest.php [new file with mode: 0644]
Morty Proxy This is a proxified and sanitized view of the page, visit original site.