Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat(plugin-vue): use transformWithOxc if rolldown-vite is detected #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2025
Merged

feat(plugin-vue): use transformWithOxc if rolldown-vite is detected #584

merged 3 commits into from
May 9, 2025

Conversation

TheAlexLichter
Copy link
Contributor

@TheAlexLichter TheAlexLichter commented May 1, 2025 •
edited
Loading

Description

When using rolldown-vite, one needs to install esbuild at the moment as transformWithEsbuild is used. Instead, this PR uses the exported transformWithOxc function if available.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 2, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@584

npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@584

commit: 5586694

sapphi-red
sapphi-red requested changes May 2, 2025
View reviewed changes
packages/plugin-vue/src/main.ts Outdated Show resolved Hide resolved
packages/plugin-vue/src/main.ts Outdated Show resolved Hide resolved
@sapphi-red sapphi-red added the p3-significant 🔨 High priority enhancement (priority) label May 2, 2025
TheAlexLichter and others added 2 commits May 2, 2025 12:38
@TheAlexLichter @sapphi-red
refactor: easier check
cd72fe2 
Co-authored-by: 翠 / green <green@sapphi.red>
@TheAlexLichter @sapphi-red
fix: oxc transform config
5586694 
Co-authored-by: 翠 / green <green@sapphi.red>
sapphi-red
sapphi-red approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@sapphi-red sapphi-red merged commit 6ac8e3a into vitejs:main May 9, 2025
9 checks passed
@TheAlexLichter TheAlexLichter deleted the perf/rolldown-vite-use-oxc branch May 9, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p3-significant 🔨 High priority enhancement (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheAlexLichter @sapphi-red
Morty Proxy This is a proxified and sanitized view of the page, visit original site.