Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/ux-twig-component
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.21.0
Choose a base ref
Loading
...
head repository: symfony/ux-twig-component
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.22.0
Choose a head ref
Loading
  • 19 commits
  • 26 files changed
  • 3 contributors

Commits on Nov 1, 2024

  1. Configuration menu
    Copy the full SHA
    da12467 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2024

  1. [TwigComponent] Ignore "nested" for Alpine & Vue attributes

    Have lost time on Twig & the website 😓
    smnandre committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    b8fdb94 View commit details
    Browse the repository at this point in the history
  2. fabbot

    smnandre committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    7c5e87f View commit details
    Browse the repository at this point in the history
  3. Performance

    Co-authored-by: Hugo Alliaume <hugo@alliau.me>
    smnandre and Kocal authored Nov 3, 2024
    Configuration menu
    Copy the full SHA
    fd16b3b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b86352f View commit details
    Browse the repository at this point in the history
  5. Improve __toString performance

    Running scenario: Short attributes, empty rendered
      __toString() time: 0.00077986717224121 seconds
      __toString2() time: 0.00049495697021484 seconds
      Improvement: 36.533170284317%
    Running scenario: Short attributes, partial rendered
      __toString() time: 0.00054383277893066 seconds
      __toString2() time: 0.00031709671020508 seconds
      Improvement: 41.692240245506%
    Running scenario: Short attributes, full rendered
      __toString() time: 0.00030899047851562 seconds
      __toString2() time: 0.00012898445129395 seconds
      Improvement: 58.256172839506%
    Running scenario: Long attributes, empty rendered
      __toString() time: 0.0038020610809326 seconds
      __toString2() time: 0.0026099681854248 seconds
      Improvement: 31.353859660124%
    Running scenario: Long attributes, partial rendered
      __toString() time: 0.0032980442047119 seconds
      __toString2() time: 0.0022611618041992 seconds
      Improvement: 31.439311790646%
    Running scenario: Long attributes, full rendered
      __toString() time: 0.00074219703674316 seconds
      __toString2() time: 0.00014185905456543 seconds
      Improvement: 80.886604561516%
    smnandre committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    e8e9b1f View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Configuration menu
    Copy the full SHA
    8d8bdc9 View commit details
    Browse the repository at this point in the history
  2. minor #2316 [TwigComponent] Optimize TwigPreLexer (smnandre)

    This PR was squashed before being merged into the 2.x branch.
    
    Discussion
    ----------
    
    [TwigComponent] Optimize TwigPreLexer
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | Issues        | Fix #...
    | License       | MIT
    
    Refactor the following methods:
    * `check`
    * `consume`
    * `consumeComponentName`
    * `consumeUntil`
    * `consumeWhitespace`
    
    Remove the following methods:
    * `addDefaultBlock`
    * `consumeAttributeName`
    * `doesStringEventuallyExist`
    
    Commits
    -------
    
    9ec2a7187 [TwigComponent] Optimize TwigPreLexer
    smnandre committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    cb2fc0f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e868099 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. [TwigComponent] Improve BlockStack performances

    BlockStack Quick Optimization
    Minor change with major impact
    smnandre committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9c2ed04 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. CS fix

    smnandre authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b0b771d View commit details
    Browse the repository at this point in the history
  2. Fix copy/paste error

    smnandre authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c33d3f8 View commit details
    Browse the repository at this point in the history
  3. bug #2342 [TwigComponent] Fix directory separator in Debug command (c…

    …lussiana, smnandre)
    
    This PR was merged into the 2.x branch.
    
    Discussion
    ----------
    
    [TwigComponent] Fix directory separator in Debug command
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | Issues        |
    | License       | MIT
    
    Component template paths are retrieved by the `SplFileInfo` class, which returns paths containing backslashes on Windows and slashes on other operating systems.
    
    So on Windows environment, the command fails as the component `Card\Card.html.twig` is not formatted into `Card:Card`
    
    Commits
    -------
    
    41d9df084 Fix copy/paste error
    3664af5d5 CS fix
    d906c6e62 fix: replace / by DIRECTORY_SEPARATOR
    smnandre committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    ca96b64 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Configuration menu
    Copy the full SHA
    db99014 View commit details
    Browse the repository at this point in the history
  2. minor #2344 [TwigComponent] Improve ComponentFactory performances (sm…

    …nandre)
    
    This PR was squashed before being merged into the 2.x branch.
    
    Discussion
    ----------
    
    [TwigComponent] Improve ComponentFactory performances
    
    ComponentFactory Quick Optimization
    
    Minor change with.. mid impact
    (on large number of renders)
    
    Commits
    -------
    
    6486933ca [TwigComponent] Improve ComponentFactory performances
    smnandre committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    0bede19 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e2da79a View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Configuration menu
    Copy the full SHA
    c473b98 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Configuration menu
    Copy the full SHA
    7ac3a12 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. bug #2328 [TwigComponent] Ignore "nested" for Alpine & Vue attributes…

    … (smnandre)
    
    This PR was squashed before being merged into the 2.x branch.
    
    Discussion
    ----------
    
    [TwigComponent] Ignore "nested" for Alpine & Vue attributes
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Issues        | Fix #1839
    | License       | MIT
    
    Have lost time on Twig & the website 😓
    
    Alternative implementation of #2325
    
    Update: Improved `__toString` performance following `@Kocal` comments
    
    ---
    Now all these attributes are directly rendered
    
    | Framework       | Prefix | Code Example                                                                                       | Documentation                                                 |
    |-----------------|---------|-------------------------------------------------------------------------------------------------------|----------------------------------------------------------------|
    | **Alpine.js**   | `x-`    | `<div x-data="{ open: false }" x-show="open"></div>`                                                 | [Documentation Alpine.js](https://alpinejs.dev/)               |
    | **Vue.js**      | `v-`    | `<input v-model="message" v-if="show">`                                                              | [Documentation Vue.js](https://vuejs.org/guide/)               |
    | **Stencil**     | `@`     | `<my-component `@onClick`="handleClick"></my-component>`                                               | [Documentation Stencil](https://stenciljs.com/docs/)           |
    | **Lit**         | `@`     | `<button `@click`="${this.handleClick}">Click me</button>`                                             | [Documentation Lit](https://lit.dev/docs/)                    |
    
    Commits
    -------
    
    7bd2854d Improve __toString performance
    cb7809f8 Add str_contains in nested method
    9f7c9c8f Performance
    34524363 fabbot
    1ed1db73 [TwigComponent] Ignore "nested" for Alpine & Vue attributes
    Kocal committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    03177a4 View commit details
    Browse the repository at this point in the history
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.