[HttpClient] Fix deprecation on PHP 8.3 #54102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Feb 28, 2024
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | - |
| License | MIT |
stof
reviewed
Feb 28, 2024
| @@ -406,7 +406,11 @@ private static function createRedirectResolver(array $options, string $host, ?ar | ||
| $redirectHeaders['no_auth'] = array_filter($redirectHeaders['no_auth'], $filterContentHeaders); | ||
| $redirectHeaders['with_auth'] = array_filter($redirectHeaders['with_auth'], $filterContentHeaders); | ||
|
|
||
| stream_context_set_option($context, ['http' => $options]); | ||
| if (\PHP_VERSION_ID >= 80300) { | ||
| stream_context_set_options($context, ['http' => $options]); |
There was a problem hiding this comment.
shouldn't we define a polyfill for stream_context_set_options in symfony/polyfill-php83 and then always use it ?
There was a problem hiding this comment.
there's one already but I thought this was simple enough to fix without the polyfill
stof
approved these changes
Feb 28, 2024
xabbuh
approved these changes
Feb 28, 2024
derrabus
approved these changes
Feb 28, 2024
OskarStark
approved these changes
Feb 29, 2024
|
Thank you @nicolas-grekas. |
This was referenced Mar 4, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.