Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Sep 10, 2025

Closes #

What I did

updated the peer deps to support the latest react native web version

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing changes made in this pull request

@dannyhw dannyhw added maintenance User-facing maintenance tasks ci:normal labels Sep 10, 2025
@dannyhw dannyhw requested a review from shilman September 10, 2025 21:12
Copy link

nx-cloud bot commented Sep 10, 2025

View your CI Pipeline Execution ↗ for commit 572dfe8

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 54s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-10 21:41:39 UTC

@shilman shilman changed the title React native: Fix react native web peer dependency version React native web: Fix RNW peer dependency version Sep 11, 2025
@shilman shilman changed the title React native web: Fix RNW peer dependency version React Native Web: Fix RNW peer dependency version Sep 11, 2025
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 11, 2025
@shilman shilman merged commit 0b13a94 into next Sep 11, 2025
57 of 60 checks passed
@shilman shilman deleted the dannyhw/fix/react-native-web-peerdep branch September 11, 2025 04:17
ndelangen pushed a commit that referenced this pull request Sep 15, 2025
…eb-peerdep

React Native Web: Fix RNW peer dependency version

(cherry picked from commit 0b13a94)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Sep 15, 2025
@github-actions github-actions bot mentioned this pull request Sep 16, 2025
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.