Switch to audit resolver to ignore requirejs vulnerability #5573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#resolve-auditNotice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
Performance report!Rough benchmark
Internal benchmark
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5573 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 238 238
Lines 9256 9256
Branches 2441 2441
=======================================
Hits 9168 9168
Misses 58 58
Partials 30 30 ☔ View full report in Codecov by Sentry. |
|
This PR has been released as part of rollup@4.19.0. You can test it via |
This was referenced Aug 11, 2024
This was referenced Aug 19, 2024
This was referenced Sep 15, 2024
This was referenced Sep 17, 2024
This was referenced Sep 19, 2024
This was referenced Sep 21, 2024
This was referenced Sep 25, 2024
This was referenced Oct 2, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
requirejsnow has an "unfixable" vulnerabilitynpm auditcan not ignore single dependencies but only e.g. alldevDependenciesdevDependenciesas some are bundled into rolluprequirejsis only used in tests where the vulnerability does not matter, and we definitely DO want to keep testing it as it is the standard AMD runtimeTherefore, I am switching from
npm audittoaudit-resolverwhich does allow to ignore single dependencies. To handle audit vulnerabilities, you should now runnpm run resolve-audit.