chore: safely call function methods on elements #13190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
thanks for the PR, i have avoid optional chain for smaller package size. |
Contributor
Author
|
Ok got it, makes sense. I switched to using the |
bluebill1049
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Safely call function methods on elements.
I optimized this locally when I was porting some of the code for my personal project, but I noticed that this optimization could potentially benefit third party integrations.
Fixes # (issue)I don't think an issue has been opened, but I noticed that AntD noted an issue here.
This minor change should make it easier to plugin "element-like" entities into the library, which may occur when integrating with a UI library.
Type of change
Checklist: