refactor: Build scripts & output directories #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rschristian
commented
May 24, 2024
Comment on lines
10
to
-11
| fs.copyFileSync(filePath('index.js'), filePath('commonjs.js')); | ||
| fs.copyFileSync(filePath('index.js.map'), filePath('commonjs.js.map')); |
There was a problem hiding this comment.
No point in copying the maps AFAIK, we don't update the source map comment, i.e., commonjs.js still has //# sourceMappingURL=index.js.map.
Could fix that, but I don't see a real need to?
JoviDeCroock
approved these changes
May 24, 2024
01f244a to
dad2550
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #362-ish
Does a few things:
dist/is now nested per exportpretty-formatdependency -- it's already inlined into the export that uses it. It's not a heavy dep, but entirely unused all the same.