Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: init command create file add packageManager field #9069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

btea
Copy link
Member

@btea btea commented Feb 9, 2025

close #9068

@btea btea requested a review from zkochan as a code owner February 9, 2025 13:48
packages/plugin-commands-init/src/init.ts Outdated Show resolved Hide resolved
packages/plugin-commands-init/src/init.ts Outdated Show resolved Hide resolved
@zkochan zkochan merged commit 483384a into pnpm:main Feb 11, 2025
9 checks passed
@btea btea deleted the feat/init-command-add-packageManager-field branch February 11, 2025 10:47
@zkochan
Copy link
Member

zkochan commented Feb 12, 2025

Not everyone will want this. We need a setting to disable it.

@btea
Copy link
Member Author

btea commented Feb 12, 2025

Maybe pass the options via the cli and add the fields if the arguments are specified.

renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 14, 2025
##### [v10.4.0](https://github.com/pnpm/pnpm/blob/HEAD/pnpm/CHANGELOG.md#1040)

##### Minor Changes

-   `pnpm approve-builds --global` works now for allowing dependencies of globally installed packages to run postinstall scripts.

-   The `pnpm add` command now supports a new flag, `--allow-build`, which allows building the specified dependencies. For instance, if you want to install a package called `bundle` that has `esbuild` as a dependency and want to allow `esbuild` to run postinstall scripts, you can run:

        pnpm --allow-build=esbuild add bundle

    This will run `esbuild`'s postinstall script and also add it to the `pnpm.onlyBuiltDependencies` field of `package.json`. So, `esbuild` will always be allowed to run its scripts in the future.

    Related PR: [#9086](pnpm/pnpm#9086).

-   The `pnpm init` command adds a `packageManager` field with the current version of pnpm CLI [#9069](pnpm/pnpm#9069). To disable this behaviour, set the `init-package-manager` setting to `false`.

##### Patch Changes

-   `pnpm approve-builds` should work after two consecutive `pnpm install` runs [#9083](pnpm/pnpm#9083).
-   Fix instruction for updating pnpm with corepack [#9101](pnpm/pnpm#9101).
-   The pnpm version specified by `packageManager` cannot start with `v`.
jelmore1674 pushed a commit to jelmore1674/build-changelog that referenced this pull request Mar 19, 2025
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [pnpm](https://pnpm.io) ([source](https://github.com/pnpm/pnpm/tree/HEAD/pnpm)) | packageManager | minor | [`10.3.0+sha512.ee592eda8815a8a293c206bb0917c4bb0ff274c50def7cbc17be05ec641fc2d1b02490ce660061356bd0d126a4d7eb2ec8830e6959fb8a447571c631d5a2442d` -> `10.4.0`](https://renovatebot.com/diffs/npm/pnpm/10.3.0/10.4.0) |

---

### Release Notes

<details>
<summary>pnpm/pnpm (pnpm)</summary>

### [`v10.4.0`](https://github.com/pnpm/pnpm/blob/HEAD/pnpm/CHANGELOG.md#1040)

[Compare Source](pnpm/pnpm@v10.3.0...v10.4.0)

##### Minor Changes

-   `pnpm approve-builds --global` works now for allowing dependencies of globally installed packages to run postinstall scripts.

-   The `pnpm add` command now supports a new flag, `--allow-build`, which allows building the specified dependencies. For instance, if you want to install a package called `bundle` that has `esbuild` as a dependency and want to allow `esbuild` to run postinstall scripts, you can run:

        pnpm --allow-build=esbuild add bundle

    This will run `esbuild`'s postinstall script and also add it to the `pnpm.onlyBuiltDependencies` field of `package.json`. So, `esbuild` will always be allowed to run its scripts in the future.

    Related PR: [#&#8203;9086](pnpm/pnpm#9086).

-   The `pnpm init` command adds a `packageManager` field with the current version of pnpm CLI [#&#8203;9069](pnpm/pnpm#9069). To disable this behaviour, set the `init-package-manager` setting to `false`.

##### Patch Changes

-   `pnpm approve-builds` should work after two consecutive `pnpm install` runs [#&#8203;9083](pnpm/pnpm#9083).
-   Fix instruction for updating pnpm with corepack [#&#8203;9101](pnpm/pnpm#9101).
-   The pnpm version specified by `packageManager` cannot start with `v`.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjkuMyIsInVwZGF0ZWRJblZlciI6IjM5LjE2OS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://gitea.justinelmore.dev/jelmore1674/build-changelog/pulls/92
Co-authored-by: Renovate Bot <renovate-bot@forgejo.justinelmore.dev>
Co-committed-by: Renovate Bot <renovate-bot@forgejo.justinelmore.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to write packageManager field for pnpm init
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.