Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: optimize thinking style #4553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025
Merged

feat: optimize thinking style #4553

merged 2 commits into from
May 15, 2025

Conversation

ensorrow
Copy link
Contributor

@ensorrow ensorrow commented May 15, 2025

Types

  • 💄 Style Changes

Background or solution

feat: optimize thinking style
image

image

Changelog

feat: optimize thinking style

Summary by CodeRabbit

  • 样式

    • 优化了“推理/思考”区域的视觉样式,增加了背景色、圆角、内边距和悬停效果,并调整了图标的大小与颜色,使界面更美观易用。
  • 文档

    • 英文界面中的“Deep Think”文本更新为“Deep Thinking”。

@ensorrow ensorrow requested a review from erha19 May 15, 2025 03:21
@ensorrow
Copy link
Contributor Author

/next

Copy link
Contributor

coderabbitai bot commented May 15, 2025

Walkthrough

本次变更主要包括对 .reasoning .thinking.reasoning_content 的样式增强,增加了过渡动画、背景色、边框圆角、内边距等视觉效果,并调整了相关图标的字体大小和颜色。同时,英文语言包中 'aiNative.chat.thinking' 的本地化字符串由 "Deep Think" 更新为 "Deep Thinking"。

Changes

文件/分组 变更摘要
packages/ai-native/src/browser/components/components.module.less 增强 .reasoning .thinking.reasoning_content 的样式,增加过渡、背景色、圆角、内边距、悬停效果,并调整相关图标样式。
packages/i18n/src/common/en-US.lang.ts 'aiNative.chat.thinking' 的英文字符串从 "Deep Think" 改为 "Deep Thinking"。

Suggested reviewers

  • hacke2
  • Aaaaash

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
warning eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > glob@7.2.3: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
packages/ai-native/src/browser/components/components.module.less (3)

557-567: 优化 CSS 过渡性能
当前使用 transition: all 0.2s ease-in-out; 会对所有属性启用过渡,可能导致不必要的重绘和性能开销。建议仅对必要属性(如 background-colorcolor)应用过渡,以减少浏览器渲染负担。


576-577: 移除冗余图标颜色设置
已在全局作用域内通过 .codicon { color: inherit; } 让所有图标继承父元素颜色,单独为 .codicon-sparkle 显式设置 color: var(--design-text-foreground) 已显得冗余,建议移除以精简样式。


578-581: 图标尺寸与间距一致性校验
.codicon-chevron-right.codicon-chevron-down 设置了 font-size: 12pxmargin-left: 2px,请在高 DPI 或不同缩放下验证显示效果,确保图标与文字及其他 UI 元素保持一致。

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 30a6932 and 4514b2d.

📒 Files selected for processing (2)
  • packages/ai-native/src/browser/components/components.module.less (1 hunks)
  • packages/i18n/src/common/en-US.lang.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
  • GitHub Check: 🚀🚀🚀 Next Version for pull request
  • GitHub Check: build (macos-latest, 20.x)
  • GitHub Check: build-windows
  • GitHub Check: build (ubuntu-latest, 20.x)
  • GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
  • GitHub Check: unittest (macos-latest, 18.x, node)
  • GitHub Check: unittest (macos-latest, 18.x, jsdom)
  • GitHub Check: unittest (ubuntu-latest, 18.x, node)
  • GitHub Check: ubuntu-latest, Node.js 20.x
🔇 Additional comments (2)
packages/i18n/src/common/en-US.lang.ts (1)

1467-1467: 确保本地化字符串更新一致性
'aiNative.chat.thinking'"Deep Think" 更新为 "Deep Thinking" 提升了语义准确性。请检查其它语言包(如 en-GB、zh-CN 等)是否需要同步更新此键值。

packages/ai-native/src/browser/components/components.module.less (1)

586-591: 验证内容区的可访问性对比度
.reasoning_content 中新增的 background: var(--design-block-background)color: var(--descriptionForeground) 配色需满足 WCAG 对比度标准,以保证文本可读性和无障碍友好性。

@opensumi
Copy link
Contributor

opensumi bot commented May 15, 2025

🎉 PR Next publish successful!

3.8.3-next-1747279534.0

Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.87%. Comparing base (30a6932) to head (4514b2d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4553   +/-   ##
=======================================
  Coverage   52.87%   52.87%           
=======================================
  Files        1677     1677           
  Lines      103358   103358           
  Branches    22390    22390           
=======================================
+ Hits        54653    54654    +1     
+ Misses      40523    40522    -1     
  Partials     8182     8182           
Flag Coverage Δ
jsdom 48.38% <ø> (+<0.01%) ⬆️
node 12.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erha19 erha19 merged commit b8b5e74 into main May 15, 2025
13 checks passed
@erha19 erha19 deleted the feat/better-thinking-style branch May 15, 2025 03:41
@erha19 erha19 mentioned this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.