Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(e2e): set NODE_ENV when running built server#969

Merged
danielroe merged 1 commit intomainnuxt/test-utils:mainfrom
fix/node-envnuxt/test-utils:fix/node-envCopy head branch name to clipboard
Oct 8, 2024
Merged

fix(e2e): set NODE_ENV when running built server#969
danielroe merged 1 commit intomainnuxt/test-utils:mainfrom
fix/node-envnuxt/test-utils:fix/node-envCopy head branch name to clipboard

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

setting NODE_ENV is necessary when running a built nuxt server as it affects how dependencies are resolved - and even runtime behaviour (whether vue router logs errors, for example)

@danielroe danielroe merged commit eaa7e0a into main Oct 8, 2024
@danielroe danielroe deleted the fix/node-env branch October 8, 2024 18:28
@github-actions github-actions Bot mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.