fix(testing): enforce commonjs module for ts-jest #30681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 01be72e.
☁️ Nx Cloud last updated this comment at |
6ea3d13 to
4581b7e
Compare
4581b7e to
edec8df
Compare
jaysoo
approved these changes
Apr 11, 2025
edec8df to
01be72e
Compare
Coly010
approved these changes
Apr 11, 2025
FrozenPandaz
approved these changes
Apr 11, 2025
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
@nx/jestgraph plugin and the@nx/jest:jestexecutor correctly force themoduleResolution: node10to be used byts-node(used byts-jest), but don't force usingmodule: commonjs, which can result in issues due to incompatiblemodule/moduleResolutionpair.Expected Behavior
The
@nx/jestgraph plugin and the@nx/jest:jestexecutor should force themoduleResolution: node10andmodule: commonjscompiler options to be used byts-node.Related Issue(s)
Fixes #