Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Language & formatting improvements#1679

Merged
legendecas merged 4 commits intonodejs:mainnodejs/node-addon-api:mainfrom
henrebotha:patch-1henrebotha/node-addon-api:patch-1Copy head branch name to clipboard
Oct 28, 2025
Merged

Language & formatting improvements#1679
legendecas merged 4 commits intonodejs:mainnodejs/node-addon-api:mainfrom
henrebotha:patch-1henrebotha/node-addon-api:patch-1Copy head branch name to clipboard

Conversation

@henrebotha
Copy link
Contributor

No description provided.

Triple backticks is for code blocks, not inline code.
doc/node-gyp.md Outdated Show resolved Hide resolved
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall change looks good to me, except a minor point. Thanks!

doc/node-gyp.md Outdated Show resolved Hide resolved
@legendecas legendecas moved this from Need Triage to In Progress in Node-API Team Project Sep 12, 2025
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@legendecas legendecas merged commit 23ce3b1 into nodejs:main Oct 28, 2025
53 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Node-API Team Project Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.