Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

test: mark test-web-locks skip on IBM i#59996

Merged
nodejs-github-bot merged 1 commit intonodejs:mainnodejs/node:mainfrom
sravani1510:ibmi-mark-test-web-locks-skipsravani1510/node:ibmi-mark-test-web-locks-skipCopy head branch name to clipboard
Oct 1, 2025
Merged

test: mark test-web-locks skip on IBM i#59996
nodejs-github-bot merged 1 commit intonodejs:mainnodejs/node:mainfrom
sravani1510:ibmi-mark-test-web-locks-skipsravani1510/node:ibmi-mark-test-web-locks-skipCopy head branch name to clipboard

Conversation

@sravani1510
Copy link
Contributor

@sravani1510 sravani1510 commented Sep 24, 2025

For the test-weblocks test it check the rss memory before and after but on IBM i this is always set to 0 from libuv

Reference:

node/src/node_process_methods.cc

Lines 229 to 233 in d2ff9da

int err = uv_resident_set_memory(&rss);
if (err)
return env->ThrowUVException(err, "uv_resident_set_memory");
fields[0] = static_cast<double>(rss);

libuv/libuv@8813dca

So, this test case can be skipped for now

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 24, 2025
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 24, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69351/

@abmusse abmusse self-requested a review September 24, 2025 13:06
abmusse
abmusse approved these changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@abmusse abmusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.43%. Comparing base (9692677) to head (17223a3).
⚠️ Report is 45 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59996      +/-   ##
==========================================
- Coverage   88.44%   88.43%   -0.02%     
==========================================
  Files         703      703              
  Lines      207532   207532              
  Branches    40007    40012       +5     
==========================================
- Hits       183562   183523      -39     
- Misses      15953    16002      +49     
+ Partials     8017     8007      -10

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 24, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69358/

@abmusse abmusse added the ibm i Issues and PRs related to the IBM i platform. label Sep 30, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 30, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69480/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 1, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69484/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 1, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69489/

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 1, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 1, 2025
@nodejs-github-bot nodejs-github-bot merged commit c08164d into nodejs:main Oct 1, 2025
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 1, 2025

Landed in c08164d

targos pushed a commit that referenced this pull request Oct 6, 2025
@sravani1510 @targos
test: mark test-web-locks skip on IBM i
77ec400 
PR-URL: #59996
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Abdirahim Musse <abdirahim.musse@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
Merged
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
@sravani1510 @aduh95
test: mark test-web-locks skip on IBM i
4206406 
PR-URL: #59996
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Abdirahim Musse <abdirahim.musse@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@abmusse abmusse abmusse approved these changes

Assignees

No one assigned

Labels

ibm i Issues and PRs related to the IBM i platform. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sravani1510 @nodejs-github-bot @lpinca @richardlau @abmusse
Morty Proxy This is a proxified and sanitized view of the page, visit original site.